-
Notifications
You must be signed in to change notification settings - Fork 10.3k
Spruce up OpenApiSchema generation #41468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks good. Do we need to add a couple test cases for Dictionary, Time* types, and IEnumerable?
The PR description says it closes the issue, the issue talks about handling TryParse and default values. Does that still need to be tracked?
a3d04dc
to
210450f
Compare
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
I changed the issue text here. There's actually potentially other things that will happen in this schema generation area.
Their omission is intentional here and mainly has to do with the fact that Stuff's Complicated ™️ .
Edit: I'm also noodling on an alternative approach for this problem which involves "merging" with the Swashbuckle-generated schema instead of overriding it altogether (unless the user explicitly did so in their |
Part of #41246
We're pursuing more fully-fledged schema generation support via microsoft/OpenAPI.NET#836 but this fixes up a few things with the current logic:
Nullable
attribute on types usingNullabilityContext
info