Changed the Rate Limiter API to action-based #41657
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
area-runtime
community-contribution
WeihanLi
reviewed
May 12, 2022
src/Middleware/RateLimiting/src/RateLimitingApplicationBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Weihan Li <[email protected]>
| @@ -29,11 +29,14 @@ public static IApplicationBuilder UseRateLimiter(this IApplicationBuilder app) | |||
| /// <param name="app"></param> | |||
| /// <param name="options"></param> | |||
| /// <returns></returns> | |||
| public static IApplicationBuilder UseRateLimiter(this IApplicationBuilder app, RateLimiterOptions options) | |||
| public static IApplicationBuilder UseRateLimiter(this IApplicationBuilder app, Action<RateLimiterOptions> options) | |||
There was a problem hiding this comment.
This'd probably be called configure now rather than options, right?
There was a problem hiding this comment.
Good catch, I missed this. configure seems to be the common naming convention for this so I'll change it. Currently pending on some back and forth in #41655 regarding whether this overload is needed or not. Once that's settled I'll update it with the latest changes
|
@Elfocrash Thanks for submitting this issue and PR. Based on the discussion in #41655 it looks like we should wait for #41667 which will make this middleware endpoint-aware. Once that's done, we'll have an API where this type of action will fit in. For now, I think we should close this PR. |
amcasey
added
area-middleware
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the Rate Limiter API to action-based
Description
The most common approach when it comes to configuring options/settings in AddXXX, UseXXX and MapXXX methods during project setup is to use the Action-based approach.
UseRateLimiterdoesn't follow that approach. This PR addresses that by allowing people to do:Fixes #41655