Skip to content

Fix UserSecretsIdAttribute generation #4177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 21, 2018
Merged

Conversation

natemcmaster
Copy link
Contributor

Follow-up to #4061

When only Microsoft.AspNetCore.App is referenced, the project will no longer have MSBuild imports from the Microsoft.Extensions.Configuration.UserSecrets package, which takes care of generating the UserSecretsIdAttribute. This ensures the attribute is still generated in default project templates without needing a new package ref to Config.UserSecrets.

@natemcmaster natemcmaster requested review from Eilon and pakrym November 21, 2018 03:59
@natemcmaster natemcmaster merged commit 40ef11c into master Nov 21, 2018
@natemcmaster natemcmaster deleted the namc/user-secrets branch November 21, 2018 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants