Update SDK #41798

SteveSandersonMS · 2022-05-23T12:23:22Z

Regular build-ops update

dougbu

This looks fine and matches my understanding of the current SDK version. But it appears none of the build jobs could find the archives. Retrying and if that doesn't work, please contact First Responders @SteveSandersonMS

SteveSandersonMS · 2022-05-24T12:05:55Z

@dougbu I've retried, and tried updating to an even newer SDK that's now available, which also fails with the same error. I've sent a message to First Responders.

dougbu · 2022-05-24T14:45:00Z

The error has changed, meaning we're passed the missing SDK problem. New issues look like breaking changes in the C++ linker. @marcpopMSFT does the following look familiar and who would have more information on the way forward❔

LINK : fatal error C1900: Il mismatch between 'P1' version '20211117' and 'P2' version '20210202' [D:\a\_work\1\s\src\Servers\IIS\AspNetCoreModuleV2\AspNetCore\AspNetCore.vcxproj]
LINK : fatal error LNK1257: code generation failed [D:\a\_work\1\s\src\Servers\IIS\AspNetCoreModuleV2\AspNetCore\AspNetCore.vcxproj]

or

LINK : fatal error C1900: Il mismatch between 'P1' version '20211117' and 'P2' version '20210202' [D:\a\_work\1\s\src\Servers\IIS\AspNetCoreModuleV2\AspNetCore\AspNetCore.vcxproj]
LINK : fatal error LNK1257: code generation failed [D:\a\_work\1\s\src\Servers\IIS\AspNetCoreModuleV2\AspNetCore\AspNetCore.vcxproj]

The strange thing is the errors occur while we're building w/ desktop msbuild. We get that program from the VS installation on the build agents and that tends to change only on Wednesdays. How is .NET SDK get involved here❔

TanayParikh · 2022-05-26T23:31:40Z

/ping on Doug's message above. Does anyone have context in the area?

Pilchie · 2022-05-26T23:38:52Z

@agocke - do you have any C++ contacts that might understand the above? Is this related to the Default Interface Methods changes maybe?

agocke · 2022-05-26T23:48:47Z

I've never seen anything like this before. Maybe @tgani-msft might have an idea

dougbu · 2022-05-27T01:51:13Z

Perhaps we should try yet-another (newer) SDK version❔

TanayParikh · 2022-05-27T04:55:24Z

Perhaps we should try yet-another (newer) SDK version❔

Just tried to do an update, but turned into a downgrade. I pulled the latest SDK from dotnet/installer and it was only 7.0.100-preview.5.22273.27.

MackinnonBuck · 2022-05-27T16:20:57Z

/azp run

azure-pipelines · 2022-05-27T16:21:16Z

Azure Pipelines successfully started running 3 pipeline(s).

TanayParikh · 2022-05-27T17:13:50Z

@MackinnonBuck I believe you'll have to try a different SDK version. The one I updated to last night doesn't seem to exist for some reason (despite acquiring it directly from dotnet/installer).

(NETCORE_ENGINEERING_TELEMETRY=InitializeToolset) Failed to install dotnet SDK from any of the specified locations.

MackinnonBuck · 2022-05-31T21:21:39Z

/azp run

azure-pipelines · 2022-05-31T21:21:59Z

Azure Pipelines successfully started running 3 pipeline(s).

MackinnonBuck · 2022-05-31T23:50:54Z

Looks like the newer SDK version has the same C++ linker issue. @tgani-msft do you have any ideas?

dougbu · 2022-06-01T22:35:57Z

@MackinnonBuck did this PR run its validation before or after you merged #41866❔ That may have included a fix for the C++ problem

MackinnonBuck · 2022-06-01T23:01:41Z

@dougbu That was before #41866 was merged. I'll start another build to see if the problem is fixed.

MackinnonBuck · 2022-06-01T23:01:49Z

/azp run

azure-pipelines · 2022-06-01T23:02:08Z

Azure Pipelines successfully started running 3 pipeline(s).

javiercn · 2022-06-02T06:13:09Z

Bumped the SDK version again, let's see

javiercn · 2022-06-02T09:05:54Z

@dougbu @MackinnonBuck seems that the fix didn't flow through just yet.

javiercn · 2022-06-02T10:35:05Z

When this PR gets in, lets make sure we also trigger #41494 as it should contain the fix we need.

dougbu · 2022-06-05T03:53:49Z

/azp run

azure-pipelines · 2022-06-05T03:54:07Z

Azure Pipelines successfully started running 3 pipeline(s).

dougbu · 2022-06-07T00:46:31Z

Problems holding this one up seem to require completion of #41999. Once that's in, will dependencies need to flow all the way through dotnet/installer before this PR can pass validation❔ I saw some comments somewhere about how we choose the compiler but am not sure whether anyone took action.

@MackinnonBuck @javiercn❔❔

dougbu · 2022-06-07T00:52:16Z

Actually, that comment was too specific.

Where exactly was the fix for the C++ compiler / linker problems❔
Do we need to wait for anything or just update the SDK version again❔

Trying the installer version

Co-authored-by: Doug Bunting <[email protected]>

BrennanConroy · 2022-06-23T20:46:46Z

eng/targets/Cpp.Common.props

+    <VCProjectVersion>15.0</VCProjectVersion>
+    <Keyword>Win32Proj</Keyword>
+    <Platform Condition="'$(Platform)' == ''">x64</Platform>
+    <PlatformToolsetVersion>v143</PlatformToolsetVersion>


FYI @HaoK
I moved the toolset and windows versions to our common Cpp props and removed them from IIS and Installers. So in case you notice them missing from IIS in the future this is why 😉

BrennanConroy · 2022-06-23T23:16:56Z

/azp run

azure-pipelines · 2022-06-23T23:17:14Z

Azure Pipelines successfully started running 3 pipeline(s).

src/Servers/IIS/AspNetCoreModuleV2/CommonLibTests/CommonLibTests.vcxproj

dougbu · 2022-06-24T01:13:42Z

A month to get this in is ugly but it's in 🎉

SteveSandersonMS requested review from a team, dougbu and wtgodbe as code owners May 23, 2022 12:23

ghost added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label May 23, 2022

dougbu approved these changes May 23, 2022

View reviewed changes

dougbu mentioned this pull request Jun 6, 2022

[main] Update dependencies from dotnet/efcore dotnet/runtime #41999

Merged

MackinnonBuck and others added 15 commits June 23, 2022 13:59

Update global.json

8a78149

Trying the installer version

Bump the SDK to a newer version

bea00bd

Update global.json

03717ed

Update global.json

8127994

Move to v143 toolset

c473400

Try 2022 agents

7c88de3

Fix v142 reference

a8215e1

Use similar public image in public builds

6026869

Update .azure/pipelines/jobs/default-build.yml

d4adee0

Co-authored-by: Doug Bunting <[email protected]>

Try Win10SDK 10941

e2ecef1

Update global.json

34371c7

Fix components trim warnings

a1b00e0

Clean up

59c6dca

Update Identity UI packaging to account for SWA packing changes

8ab14a6

Add ToArray() to MemoryOutputCacheStoreTests

a94f421

javiercn force-pushed the stevesa/update-sdk-2022-may branch from fc213f1 to a94f421 Compare June 23, 2022 12:03

javiercn and others added 6 commits June 23, 2022 14:52

Fix MemoryOutputCacheStoreTests properly

b528940

More utf8 fixes

5cec238

try different images

4a25ac7

whoops

35a62ca

common cpp settings

ee30df7

revet images

4ea6645

BrennanConroy reviewed Jun 23, 2022

View reviewed changes

dougbu approved these changes Jun 23, 2022

View reviewed changes

src/Servers/IIS/AspNetCoreModuleV2/CommonLibTests/CommonLibTests.vcxproj Show resolved Hide resolved

HaoK merged commit df9a5d4 into main Jun 24, 2022

HaoK deleted the stevesa/update-sdk-2022-may branch June 24, 2022 01:11

ghost added this to the 7.0-preview7 milestone Jun 24, 2022

Update SDK #41798

Update SDK #41798

Uh oh!

Conversation

SteveSandersonMS commented May 23, 2022

Uh oh!

dougbu left a comment

Choose a reason for hiding this comment

Uh oh!

SteveSandersonMS commented May 24, 2022

Uh oh!

dougbu commented May 24, 2022

Uh oh!

TanayParikh commented May 26, 2022

Uh oh!

Pilchie commented May 26, 2022

Uh oh!

agocke commented May 26, 2022

Uh oh!

dougbu commented May 27, 2022

Uh oh!

TanayParikh commented May 27, 2022

Uh oh!

MackinnonBuck commented May 27, 2022

Uh oh!

azure-pipelines bot commented May 27, 2022

Uh oh!

TanayParikh commented May 27, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MackinnonBuck commented May 31, 2022

Uh oh!

azure-pipelines bot commented May 31, 2022

Uh oh!

MackinnonBuck commented May 31, 2022

Uh oh!

dougbu commented Jun 1, 2022

Uh oh!

MackinnonBuck commented Jun 1, 2022

Uh oh!

MackinnonBuck commented Jun 1, 2022

Uh oh!

azure-pipelines bot commented Jun 1, 2022

Uh oh!

javiercn commented Jun 2, 2022

Uh oh!

javiercn commented Jun 2, 2022

Uh oh!

javiercn commented Jun 2, 2022

Uh oh!

dougbu commented Jun 5, 2022

Uh oh!

azure-pipelines bot commented Jun 5, 2022

Uh oh!

dougbu commented Jun 7, 2022

Uh oh!

dougbu commented Jun 7, 2022

Uh oh!

BrennanConroy Jun 23, 2022

Choose a reason for hiding this comment

Uh oh!

BrennanConroy commented Jun 23, 2022

Uh oh!

azure-pipelines bot commented Jun 23, 2022

Uh oh!

Uh oh!

dougbu commented Jun 24, 2022

Uh oh!

Uh oh!

TanayParikh commented May 27, 2022 •

edited

Loading