Skip to content

[user-jwts] Read and generate secrets ID with SecretsManager #42006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 9, 2022

Conversation

captainsafia
Copy link
Member

Closes #41975 and part of #41888.

  • Change up build configuration to support referencing dotnet-user-secrets
  • Use SecretManager build target to extract user secrets ID
  • Create secret ID if it has not been defined

@captainsafia captainsafia requested review from a team, dougbu, wtgodbe and Pilchie as code owners June 3, 2022 01:05
@captainsafia captainsafia added area-commandlinetools Includes: Command line tools, dotnet-dev-certs, dotnet-user-jwts, and OpenAPI old-area-web-frameworks-do-not-use *DEPRECATED* This label is deprecated in favor of the area-mvc and area-minimal labels feature-userjwts The `dotnet user-jwts` CLI tool labels Jun 3, 2022
@captainsafia captainsafia enabled auto-merge (squash) June 9, 2022 15:55
@captainsafia captainsafia merged commit 9ad5dc9 into dotnet:main Jun 9, 2022
@ghost ghost added this to the 7.0-preview6 milestone Jun 9, 2022
captainsafia added a commit to captainsafia/aspnetcore that referenced this pull request Jun 13, 2022
…42006)

* [user-jwts] Read secrets ID from SecretsManager and generate missing secrets
* Address feedback from review
* Add shared localizations strings for secrets
* Update localization and address feedback
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-commandlinetools Includes: Command line tools, dotnet-dev-certs, dotnet-user-jwts, and OpenAPI feature-userjwts The `dotnet user-jwts` CLI tool old-area-web-frameworks-do-not-use *DEPRECATED* This label is deprecated in favor of the area-mvc and area-minimal labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

user-jwts should just create the UserSecretsId if not found
5 participants