Skip to content

[main] Update dependencies from dotnet/source-build-externals #43143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Aug 8, 2022

This pull request updates the following dependencies

From https://github.com/dotnet/source-build-externals

  • Subscription: 93759b2e-8cec-490d-6e3a-08da700278bb
  • Build: 20220805.1
  • Date Produced: August 5, 2022 8:08:26 PM UTC
  • Commit: 85d7e996e497861648ffbfd0e929b2b627ce7f46
  • Branch: refs/heads/main

…nals build 20220805.1

Microsoft.SourceBuild.Intermediate.source-build-externals
 From Version 7.0.0-alpha.1.22370.1 -> To Version 7.0.0-alpha.1.22405.1
@dotnet-maestro dotnet-maestro bot requested review from a team, dougbu and wtgodbe as code owners August 8, 2022 12:42
@ghost ghost added area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework Type: Dependency Update 🔼 labels Aug 8, 2022
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving dependency update.

@sebastienros
Copy link
Member

@JamesNK I think this update is breaking the grpc templates, there is a compilation error with the generated classes:

2022-08-08T13:26:25.3488717Z [xUnit.net 00:00:18.37]     Templates.Test.GrpcTemplateTest.GrpcTemplate(useProgramMain: False) [FAIL]
2022-08-08T13:26:25.3489099Z [xUnit.net 00:00:18.37]       Project new grpc  failed to publish. Exit code 1.
2022-08-08T13:26:25.3489140Z [xUnit.net 00:00:18.37]       /datadisks/disk1/work/B32B09A4/p/dotnet-cli/dotnet publish --no-restore -c Release /bl \nStdErr: \nStdOut: MSBuild version 17.4.0-preview-22366-04+d2871ca13 for .NET
2022-08-08T13:26:25.3489249Z [xUnit.net 00:00:18.37]       /datadisks/disk1/work/B32B09A4/p/dotnet-cli/sdk/7.0.100-rc.1.22375.2/MSBuild.dll -maxcpucount -property:_IsPublishing=true -property:Configuration=Release -target:Publish -verbosity:m /bl ./AspNet.ylrfafx4n0au.csproj
2022-08-08T13:26:25.3489303Z [xUnit.net 00:00:18.37]       /datadisks/disk1/work/B32B09A4/p/dotnet-cli/sdk/7.0.100-rc.1.22375.2/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.RuntimeIdentifierInference.targets(219,5): message NETSDK1057: You are using a preview version of .NET. See: https://aka.ms/dotnet-support-policy [/datadisks/disk1/work/B32B09A4/w/BDCD09FD/e/Templates/BaseFolder/AspNet.ylrfafx4n0au/AspNet.ylrfafx4n0au.csproj]
2022-08-08T13:26:25.3489494Z [xUnit.net 00:00:18.37]       /datadisks/disk1/work/B32B09A4/w/BDCD09FD/e/Templates/BaseFolder/AspNet.ylrfafx4n0au/obj/Release/net7.0/Protos/Greet.cs(8,7): error CS8981: The type name 'pb' only contains lower-cased ascii characters. Such names may become reserved for the language. [/datadisks/disk1/work/B32B09A4/w/BDCD09FD/e/Templates/BaseFolder/AspNet.ylrfafx4n0au/AspNet.ylrfafx4n0au.csproj]
2022-08-08T13:26:25.4205298Z [xUnit.net 00:00:18.37]       /datadisks/disk1/work/B32B09A4/w/BDCD09FD/e/Templates/BaseFolder/AspNet.ylrfafx4n0au/obj/Release/net7.0/Protos/Greet.cs(9,7): error CS8981: The type name 'pbc' only contains lower-cased ascii characters. Such names may become reserved for the language. [/datadisks/disk1/work/B32B09A4/w/BDCD09FD/e/Templates/BaseFolder/AspNet.ylrfafx4n0au/AspNet.ylrfafx4n0au.csproj]
2022-08-08T13:26:25.4205492Z [xUnit.net 00:00:18.37]       /datadisks/disk1/work/B32B09A4/w/BDCD09FD/e/Templates/BaseFolder/AspNet.ylrfafx4n0au/obj/Release/net7.0/Protos/Greet.cs(10,7): error CS8981: The type name 'pbr' only contains lower-cased ascii characters. Such names may become reserved for the language. [/datadisks/disk1/work/B32B09A4/w/BDCD09FD/e/Templates/BaseFolder/AspNet.ylrfafx4n0au/AspNet.ylrfafx4n0au.csproj]
2022-08-08T13:26:25.4205776Z [xUnit.net 00:00:18.37]       /datadisks/disk1/work/B32B09A4/w/BDCD09FD/e/Templates/BaseFolder/AspNet.ylrfafx4n0au/obj/Release/net7.0/Protos/Greet.cs(11,7): error CS8981: The type name 'scg' only contains lower-cased ascii characters. Such names may become reserved for the language. [/datadisks/disk1/work/B32B09A4/w/BDCD09FD/e/Templates/BaseFolder/AspNet.ylrfafx4n0au/AspNet.ylrfafx4n0au.csproj]
2022-08-08T13:26:25.4205831Z [xUnit.net 00:00:18.37]       /datadisks/disk1/work/B32B09A4/w/BDCD09FD/e/Templates/BaseFolder/AspNet.ylrfafx4n0au/obj/Release/net7.0/Protos/GreetGrpc.cs(8,7): error CS8981: The type name 'grpc' only contains lower-cased ascii characters. Such names may become reserved for the language. [/datadisks/disk1/work/B32B09A4/w/BDCD09FD/e/Templates/BaseFolder/AspNet.ylrfafx4n0au/AspNet.ylrfafx4n0au.csproj]

I assume the source is in the grpc repos but couldn't find where it's generated.

@JamesNK
Copy link
Member

JamesNK commented Aug 8, 2022

It's this problem: #41716

A proper fix is coming in a month or two (suppress the warning in the generated source), but in the meantime, it will need to be suppressed somewhere else.

@sebastienros
Copy link
Member

Is this an error since recently? The referenced issue mentions warnings.

@JamesNK
Copy link
Member

JamesNK commented Aug 8, 2022

It's been a problem since that issue (May). I don't know why it's only a problem with source build now. Maybe the analyzer has only just started running with source build.

@dotnet-maestro dotnet-maestro bot merged commit 25a5cd8 into main Aug 9, 2022
@dotnet-maestro dotnet-maestro bot deleted the darc-main-3040e8e9-72ba-4548-b345-cd2ba6dcc7b8 branch August 9, 2022 18:16
@ghost ghost added this to the 7.0-rc1 milestone Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework Type: Dependency Update 🔼
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants