Copy invocation handler list in Java client #43402
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrennanConroy
added
area-signalr
halter73
approved these changes
Aug 19, 2022
| lock.lock(); | ||
| List<InvocationHandler> handlers = this.handlers.get(key); | ||
| if (handlers != null) { | ||
| handlers.remove(handler); |
There was a problem hiding this comment.
Instead of mutating the existing list, wouldn't it likely be more efficient to make this copy-on-write and replace the reference so we don't have to copy it every time in get()?
There was a problem hiding this comment.
Hmm, that's a good point. Looks like that's what we do in the .NET client so at least we were smart there 😄
|
Approved for RC1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No one reported this even though it failed a few times...
Root cause was that we were removing an
.onhandler from the list while an invocation was currently looping over the list, which of course can cause issues. In our other clients we copy the list whenever we are about to loop over it, so doing the same in the Java client.