[SignalR] [Java] Log 'WebSocket stopped' once #43532
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrennanConroy
added
area-signalr
BrennanConroy
changed the title
halter73
approved these changes
Sep 8, 2022
| @@ -82,7 +82,9 @@ public void setOnClose(TransportOnClosedCallback onCloseCallback) { | |||
|
|
|||
| @Override | |||
| public Completable stop() { | |||
| return webSocketClient.stop().doOnEvent(t -> logger.info("WebSocket connection stopped.")); | |||
| Completable stop = webSocketClient.stop(); | |||
| stop.onErrorComplete().subscribe(() -> logger.info("WebSocket connection stopped.")); | |||
There was a problem hiding this comment.
Is it possible to write a test that we're no longer writing this four times?
BrennanConroy
force-pushed
the
brecon/javalog
branch
from
139a7f4 to
505f704
Compare
BrennanConroy
force-pushed
the
brecon/javalog
branch
from
505f704 to
478807b
Compare
ghost
added this to the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed "WebSocket connection stopped." being logged 4 times when calling
hubConnection.Stop().blockingAwait();This was because we were returning the Completable from
doOnEventwhich if subscribed to will repeat per subscription. Plus, we were returning the stop task directly which would also repeat itself per subscription, and we were subscribing to it ourselves first to make sure it was a hot-observable.