[release/7.0] Set MSBUILDLOGALLENVIRONMENTVARIABLES in most CI jobs
#43644
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dougbu
commented
Aug 30, 2022
dougbu
commented
- should affect most of our pipelines though not a few post-build jobs
- as we saw in Update SDK #43028, binary logs no longer include all environment variables by default
- this change captures the environment variables not visibly referenced in our projects etc.
- fix avoids a need to add the override later to debug an issue, at the cost of larger .binlog files
- should affect most of our pipelines though not a few post-build jobs - as we saw in #43028, binary logs no longer include all environment variables by default - this change captures the environment variables not visibly referenced in our projects etc. - fix avoids a need to add the override later to debug an issue, at the cost of larger .binlog files
dougbu
added
area-infrastructure
|
Hey @dotnet/aspnet-build, looks like this PR is something you want to take a look at. |
|
/fyi @rainersigwald @Forgind and @baronfel |
Forgind
approved these changes
Aug 30, 2022
Merged
wtgodbe
approved these changes
Aug 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.