Skip to content

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Sep 9, 2022

This pull request updates the following dependencies

From https://github.com/dotnet/arcade

  • Subscription: a1e8257b-e869-4455-b087-08da7ef6355d
  • Build: 20220908.5
  • Date Produced: September 9, 2022 5:25:04 AM UTC
  • Commit: 622c2dc5ced5df5af002a3b06a52f9584b726b28
  • Branch: refs/heads/release/7.0
  • Updates to .NET SDKs:
    • Updates sdk.version to 7.0.100-rc.1.22425.9
    • Updates tools.dotnet to 7.0.100-rc.1.22425.9

…908.5

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Helix.Sdk
 From Version 7.0.0-beta.22423.1 -> To Version 7.0.0-beta.22458.5
@dotnet-maestro dotnet-maestro bot requested review from a team, dougbu and wtgodbe as code owners September 9, 2022 16:36
@ghost ghost added area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework Type: Dependency Update 🔼 labels Sep 9, 2022
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving dependency update.

@MackinnonBuck
Copy link
Member

@JamesNK I see you've done some work on DataProtection trimming - would you be able to take a look at these warnings?

@JamesNK JamesNK requested a review from Pilchie as a code owner September 10, 2022 08:22
@JamesNK
Copy link
Member

JamesNK commented Sep 10, 2022

Fixed new data protection trim warning.

@joperezr
Copy link
Member

Would be good for somebody to validate, but the remaining errors are all link warnings of type:
Unused 'UnconditionalSuppressMessageAttribute' for warning 'IL2077'. Consider removing the unused warning suppression. which I believe is a new warning on the linker. I've pulled this locally and just added the NoWarn="IL2121" to the ILLink task invocation on projects WasmLinkerTest.csproj and LinkabilityChecker.csproj and the build passes. it would be good to get either someone from the linker team or the aspnet team to validate the right way to move forward, since this PR is currently blocking the update of dotnet/runtime in PR #43904

@joperezr
Copy link
Member

joperezr commented Sep 10, 2022

After a closer look, seems like the warnings are mainly caused by - now unnecessary - warning suppressions passed to the linker. They were probably needed before but the linker must now understand that they are not needed.

@JamesNK
Copy link
Member

JamesNK commented Sep 11, 2022

Great, IL2121 is back.

We dealt with it in the main branch in this PR - #43028 (comment)

The changes may need to be made to release/7.0. You can look at the changes and see the places IL2121 was added to suppressions.

@TanayParikh
Copy link
Contributor

The changes may need to be made to release/7.0. You can look at the changes and see the places IL2121 was added to suppressions.

43467be

@TanayParikh
Copy link
Contributor

@JamesNK @joperezr looks like we're still encountering IL2121 despite 43467be, any idea what may be going on here?

@joperezr
Copy link
Member

As an FYI, this is no longer blocking the ingestion from dotnet/runtime as the one change that required the SDK bump was rolled back temporarily. If we want to merge this PR, we can just revert the global.json change that is bumping the SDK which will get rid of all of the new IL warnings. That said, the change in dotnet/runtime will be redone after RC1 ships, and there will be a new SDK bump to match RC1 version, and at that point we will need to fix all of the warnings that the new SDK causes.

@dougbu
Copy link
Contributor

dougbu commented Sep 13, 2022

@TanayParikh let's hold off until RC1 ships and we can use the released RC1 SDK. I'd rather not undo the IL-related changes only to need them reinvented later this week.

@JamesNK
Copy link
Member

JamesNK commented Sep 14, 2022

I think the solution here is a lot of the changes - trimming and no warn - from #43028 should be applied.

And I noticed I fixed the same trimming issue in a different way in this PR than in main. I want to update this PR to be the same.

@JamesNK JamesNK requested a review from a team as a code owner September 14, 2022 00:47
@dotnet-maestro dotnet-maestro bot merged commit 8f9d9f9 into release/7.0 Sep 14, 2022
@dotnet-maestro dotnet-maestro bot deleted the darc-release/7.0-052fc519-fc85-4cfc-a919-0c3e95d9bb79 branch September 14, 2022 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework Type: Dependency Update 🔼

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants