-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[release/7.0] Update dependencies from dotnet/arcade #43880
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/7.0] Update dependencies from dotnet/arcade #43880
Conversation
…908.5 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Helix.Sdk From Version 7.0.0-beta.22423.1 -> To Version 7.0.0-beta.22458.5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Auto-approving dependency update.
@JamesNK I see you've done some work on DataProtection trimming - would you be able to take a look at these warnings? |
Fixed new data protection trim warning. |
Would be good for somebody to validate, but the remaining errors are all link warnings of type: |
After a closer look, seems like the warnings are mainly caused by - now unnecessary - warning suppressions passed to the linker. They were probably needed before but the linker must now understand that they are not needed. |
Great, IL2121 is back. We dealt with it in the main branch in this PR - #43028 (comment) The changes may need to be made to release/7.0. You can look at the changes and see the places IL2121 was added to suppressions. |
|
As an FYI, this is no longer blocking the ingestion from dotnet/runtime as the one change that required the SDK bump was rolled back temporarily. If we want to merge this PR, we can just revert the global.json change that is bumping the SDK which will get rid of all of the new IL warnings. That said, the change in dotnet/runtime will be redone after RC1 ships, and there will be a new SDK bump to match RC1 version, and at that point we will need to fix all of the warnings that the new SDK causes. |
@TanayParikh let's hold off until RC1 ships and we can use the released RC1 SDK. I'd rather not undo the IL-related changes only to need them reinvented later this week. |
I think the solution here is a lot of the changes - trimming and no warn - from #43028 should be applied. And I noticed I fixed the same trimming issue in a different way in this PR than in main. I want to update this PR to be the same. |
This pull request updates the following dependencies
From https://github.com/dotnet/arcade