[Blazor] MSAL updates #43954
Merged
[Blazor] MSAL updates #43954
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
MackinnonBuck
approved these changes
Sep 13, 2022
src/Components/WebAssembly/Authentication.Msal/src/Interop/AuthenticationService.ts
Show resolved
Hide resolved
src/Components/WebAssembly/Authentication.Msal/src/Interop/AuthenticationService.ts
Show resolved
Hide resolved
src/Components/WebAssembly/Authentication.Msal/src/Interop/AuthenticationService.ts
Show resolved
Hide resolved
src/Components/WebAssembly/Authentication.Msal/src/Interop/AuthenticationService.ts
Show resolved
Hide resolved
src/Components/WebAssembly/Authentication.Msal/src/Interop/AuthenticationService.ts
Show resolved
Hide resolved
* Update MSAL * Replace history on navigation * Add logging * Leverage crypto.randomUUID * Fix support for requesting additional tokens interactively. * Prevent triming MsalProviderOptions.
javiercn
force-pushed
the
javiercn/blazor-msal-updates
branch
from
797d8f9 to
ac2883b
Compare
javiercn
requested review from
Tratcher,
halter73,
BrennanConroy,
JamesNK,
a team,
dougbu and
wtgodbe
as code owners
javiercn
removed request for
a team,
halter73,
JamesNK,
Tratcher,
dougbu,
BrennanConroy and
wtgodbe
|
/azp run aspnetcore-helix-matrix |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
|
/azp run aspnetcore-richnav |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
javiercn
force-pushed
the
javiercn/blazor-msal-updates
branch
from
959df48 to
0ee2e19
Compare
javiercn
force-pushed
the
javiercn/blazor-msal-updates
branch
from
0ee2e19 to
d1cf7f3
Compare
|
@Pilchie this should be good to go. The PR updates the underlying msal.js library as well as addresses the issues mentioned above and does some additional cleanups on the implementation. The issues are bundled together because this area requires manual validation, and it is complex to do so. I have done manual validation for AAD and AAD B2C and we also have CTI in place in case I missed anything. |
|
Approved for .NET 7 RC2. |
This was referenced Sep 15, 2022
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #43063, #39311, #29384