-
Notifications
You must be signed in to change notification settings - Fork 10.3k
Add Uri StringSyntaxAttribute syntaxes #44570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for your PR, @blouflashdb. Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
…flashdb/aspnetcore into addUriStringSyntaxAttribute
Well somehow I can't use it in HubConnectionBuilderHttpExtensions.cs for some reason. Azure Pipelines |
The SignalR client also targets .NET Framework, which doesn't have that attribute. To work around this:
It doesn't matter that the attribute is internal and in a different assembly. As long as the type name and namespace match, tooling and other apps can use it. |
Thanks, I think I got it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RelativeOrAbsolute would be the default assumption so there is no need to explicitly specify it.
Otherwise, LGTM
Add Uri StringSyntaxAttribute syntaxes
Description
Adds uri StringSyntaxAttribute syntaxes to all public APIs where an uri is expected.
Closes Uri Task in #44535