Improved rate limiting tests #45541
Merged
Improved rate limiting tests #45541
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
area-runtime
community-contribution
|
Thanks for your PR, @MadL1me. Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
|
|
MadL1me
changed the title
MadL1me
commented
Dec 11, 2022
MadL1me
force-pushed
the
MadL1me/rate-limit-test-improvements
branch
from
14302d3 to
dd3ef30
Compare
wtgodbe
reviewed
Dec 12, 2022
|
|
||
| namespace Microsoft.AspNetCore.RateLimiting; | ||
|
|
||
| internal class TestEndpointBuilder : EndpointBuilder |
There was a problem hiding this comment.
Please rename this file to TestEndpointBuilder.cs
wtgodbe
requested changes
Dec 12, 2022
wtgodbe
approved these changes
Dec 12, 2022
|
Looks great! Will merge once CI passes. |
|
@wtgodbe Done! Fixed file naming and removed project from solution filter. I would be happy to work on other "help wanted issues". Currently found 2 more interesting issues related to RateLimiter as well. |
amcasey
added
area-middleware
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved rate limiting middleware tests
Added rate limiting middleware tests improvements, based on #43298 issue
Description
RateLimiterEndpointConventionBuilderExtensionswhere applicableAssert-Act-Arrangecomments for more clarification