Make ResponseCompression call DisposeAsync #4604
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JunTaoLuo
approved these changes
Dec 12, 2018
halter73
reviewed
Dec 12, 2018
| @@ -39,13 +39,9 @@ internal class BodyWrapperStream : Stream, IHttpBufferingFeature, IHttpSendFileF | |||
| _innerSendFileFeature = innerSendFileFeature; | |||
| } | |||
|
|
|||
| protected override void Dispose(bool disposing) | |||
| internal ValueTask FinishCompressionAsync() | |||
There was a problem hiding this comment.
We should probably add a regression test verifying that disposing the ResponseCompression stream doesn't end/poison the stream anymore.
halter73
approved these changes
Dec 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
aspnet/BasicMiddleware#247
GZipStream.Dispose calls sync Write and Flush. This causes threads to get blocked and can starve the threadpool. In 3.0 we can call the new DisposeAsync instead.