-
Notifications
You must be signed in to change notification settings - Fork 10.5k
Mark API from 7 as shipped #46069
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mark API from 7 as shipped #46069
Conversation
I checked But, from the CI errors, it looks like some symbols are missing from the Unshipped files still… I also get the same lack of output from |
Correct, I didn't encounter any instances where I'd have to do this. Which makes sense, if those nullability changes should never have been in Unshipped in the first place, this PR wouldn't have to touch them (if they're already in Shipped, they'll stay there)
Argh, yep, something's wrong. Weird, it passed for me locally. Will take a look.
Something's up there, there's definitely differences - e.g.: https://github.com/wtgodbe/aspnetcore/blob/wtgodbe/Api7/src/Components/Components/src/PublicAPI.Unshipped.txt |
Seems to working for me now locally |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've spot-checked some of the changes. Thanks @wtgodbe !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checked a few things locally:
- Very few (7) Shipped files differ from what's now in release/7.0. The differences relate to
- Renaming for the
net7.0
->net8.0
transition - Slight ordering changes in renamed files
- Newly-nullable public surface
- The new src/Servers/Kestrel/Transport.NamedPipes/src/ project
- 24 Unshipped files contain various changes. Most seem to be removals or small additions. That's fine as long as the CI agrees.
Only failure is the expected one in Code Check - merging |
Took all of the .shipped files from #46042, built the repo, and fixed errors one-by-one.