Skip to content

Add section to UpdatingMajorVersionAndTFM.md about marking APIs shipped #46088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 19, 2023

Conversation

wtgodbe
Copy link
Member

@wtgodbe wtgodbe commented Jan 13, 2023

No description provided.

@wtgodbe wtgodbe requested a review from a team January 13, 2023 18:18
Copy link
Contributor

@dougbu dougbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine so far but

  1. Sentences mentioning RepoTasks as an exception are no longer correct
  2. Suggest moving the template rebranding (precedence and identity updates) up into this section

@mkArtakMSFT mkArtakMSFT added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Jan 18, 2023
@ghost
Copy link

ghost commented Jan 18, 2023

Hey @dotnet/aspnet-build, looks like this PR is something you want to take a look at.

Copy link
Member

@captainsafia captainsafia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Side note: the list is getting long. I wonder if it would help with readability to have headings separating the major sections instead of using sub-bullets for each section.

@wtgodbe
Copy link
Member Author

wtgodbe commented Jan 19, 2023

Sentences mentioning RepoTasks as an exception are no longer correct

This isn't true yet, it's still an exception until #45973 is done.

Suggest moving the template rebranding (precedence and identity updates) up into this section

Will do

@wtgodbe
Copy link
Member Author

wtgodbe commented Jan 19, 2023

Actually, the precedence section can go away after #45995 is done, I'll leave it for now rather than splitting it into 2 sections (one for precedence, one for TFM) which should be redundant before 9

@wtgodbe
Copy link
Member Author

wtgodbe commented Jan 19, 2023

#46173

@wtgodbe
Copy link
Member Author

wtgodbe commented Jan 19, 2023

CI isn't reporting - @dotnet/dnceng is there a known outage right now?

Force-merging since this is just a change to a .md file.

@wtgodbe wtgodbe merged commit 1dd6f45 into main Jan 19, 2023
@wtgodbe wtgodbe deleted the wtgodbe-patch-1 branch January 19, 2023 19:37
@ghost ghost added this to the 8.0-preview1 milestone Jan 19, 2023
@MattGal
Copy link
Member

MattGal commented Jan 19, 2023

CI isn't reporting - @dotnet/dnceng is there a known outage right now?

Force-merging since this is just a change to a .md file.

There was some kind of GitHub degradation going on. Closing / reopening PRs seems to unblock it.

@ghost
Copy link

ghost commented Jan 19, 2023

Hi @MattGal. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants