-
Notifications
You must be signed in to change notification settings - Fork 10.3k
Add section to UpdatingMajorVersionAndTFM.md about marking APIs shipped #46088
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fine so far but
- Sentences mentioning
RepoTasks
as an exception are no longer correct - Suggest moving the template rebranding (
precedence
andidentity
updates) up into this section
Hey @dotnet/aspnet-build, looks like this PR is something you want to take a look at. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Side note: the list is getting long. I wonder if it would help with readability to have headings separating the major sections instead of using sub-bullets for each section.
This isn't true yet, it's still an exception until #45973 is done.
Will do |
Actually, the precedence section can go away after #45995 is done, I'll leave it for now rather than splitting it into 2 sections (one for precedence, one for TFM) which should be redundant before 9 |
CI isn't reporting - @dotnet/dnceng is there a known outage right now? Force-merging since this is just a change to a .md file. |
There was some kind of GitHub degradation going on. Closing / reopening PRs seems to unblock it. |
Hi @MattGal. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context. |
No description provided.