Fix HttpSys Caching_SendFileWithFullContentLength_Cached test #4630
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JunTaoLuo
reviewed
Dec 12, 2018
| @@ -21,7 +21,7 @@ public class ResponseCachingTests | |||
|
|
|||
| public ResponseCachingTests() | |||
| { | |||
| _absoluteFilePath = Directory.GetFiles(Directory.GetCurrentDirectory()).First(); | |||
| _absoluteFilePath = Path.Combine(Directory.GetCurrentDirectory(), "Microsoft.AspNetCore.Server.HttpSys.dll"); | |||
There was a problem hiding this comment.
Hmm, why not a test specific text file that we include as content? That would probably be more stable.
There was a problem hiding this comment.
shrug when we're not interested in the contents of the file then any file will do.
There was a problem hiding this comment.
That was probably the reasoning behind .First() but apparently that can cause issues.
muratg
approved these changes
Dec 13, 2018
JunTaoLuo
approved these changes
Dec 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/aspnet/AspNetCore-Internal/issues/1500
The test was picking the first file from the local directory and using it as test content. For netcoreapp2 this was Microsoft.AspNetCore.Server.HttpSys.dll, but for net461 it was Castle.Core.dll. Castle was much larger so it caused different behavior and failed the net461 tests.