Update gRPC template dependencies for AOT #46447
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesNK
force-pushed
the
jamesnk/grpc-template-aot
branch
from
95d8a79 to
9e45634
Compare
davidfowl
reviewed
Feb 5, 2023
davidfowl
approved these changes
Feb 5, 2023
JamesNK
commented
Feb 7, 2023
| @@ -12,6 +12,7 @@ | |||
|
|
|||
| <ItemGroup> | |||
| <PackageReference Include="Grpc.AspNetCore" Version="${GrpcAspNetCoreVersion}" /> | |||
| <PackageReference Include="Google.Protobuf" Version="3.22.0-rc2" /> | |||
There was a problem hiding this comment.
Note, this is hard coded because:
- I don't want to update other places that use Google.Protobuf, such as Microsoft.AspNetCore.Grpc.JsonTranscoding, to use it.
- It will be removed in a month or two.
ghost
added this to the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Grpc.* 2.51.0 fixes a couple of AOT warnings
Google.Protobuf also fixes warnings. It's not possible to get a full version in time for preview 2. I have added an RC version directly to the project template as a temporary measure. It overrides what is referenced by Grpc.AspNetCore.