Skip to content

Revert "Update SDK (#46919)" #46943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 28, 2023
Merged

Revert "Update SDK (#46919)" #46943

merged 1 commit into from
Feb 28, 2023

Conversation

mitchdenny
Copy link
Member

Reverting SDK version due to CI build failures:

Processing binlog D:\a\_work\1\s/artifacts/log/Release/Build.binlog into solution at directory D:\a\_work\1\a/sourceIndex/
Unhandled exception. System.NotSupportedException: Unsupported log file format. Latest supported version is 15, the log file has version 16.
   at Microsoft.Build.Logging.StructuredLogger.BinLogReader.Replay(Stream stream, Progress progress) in C:\MSBuildStructuredLog\src\StructuredLogger\BinaryLogger\BinLogReader.cs:line 74
   at Microsoft.Build.Logging.StructuredLogger.BinLogReader.Replay(String sourceFilePath, Progress progress) in C:\MSBuildStructuredLog\src\StructuredLogger\BinaryLogger\BinLogReader.cs:line 50
   at Microsoft.Build.Logging.StructuredLogger.BinLogReader.Replay(String sourceFilePath) in C:\MSBuildStructuredLog\src\StructuredLogger\BinaryLogger\BinLogReader.cs:line 39
   at Microsoft.SourceBrowser.BinLogParser.BinLogCompilerInvocationsReader.<>c__DisplayClass1_0.<ExtractInvocations>b__0() in D:\a\_work\1\s\src\SourceBrowser\src\BinLogParser\BinLogReader.cs:line 58
   at System.Lazy`1.ViaFactory(LazyThreadSafetyMode mode)
   at System.Lazy`1.ExecutionAndPublication(LazyHelper executionAndPublication, Boolean useDefaultConstructor)
   at System.Lazy`1.CreateValue()
   at System.Lazy`1.get_Value()
   at Microsoft.SourceBrowser.BinLogParser.BinLogCompilerInvocationsReader.ExtractInvocations(String binLogFilePath) in D:\a\_work\1\s\src\SourceBrowser\src\BinLogParser\BinLogReader.cs:line 63
   at BinLogToSln.Program.Main(String[] args) in D:\a\_work\1\s\src\SourceBrowser\src\BinLogToSln\Program.cs:line 77

Last time this happened we needed to do this:

#45982

However it can take a few days to get the package updated in the feed, hence the revert.

@mitchdenny mitchdenny requested review from a team, dougbu and wtgodbe as code owners February 28, 2023 22:11
@ghost ghost added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Feb 28, 2023
@wtgodbe
Copy link
Member

wtgodbe commented Feb 28, 2023

Force-merging to get official builds working

@wtgodbe wtgodbe merged commit e9ced2f into dotnet:main Feb 28, 2023
@ghost ghost added this to the 8.0-preview3 milestone Feb 28, 2023
@mitchdenny
Copy link
Member Author

Hopefully we don't need to revert EF as well ;)

@ghost
Copy link

ghost commented Feb 28, 2023

Hi @mitchdenny. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context.

wtgodbe added a commit that referenced this pull request Feb 28, 2023
wtgodbe added a commit that referenced this pull request Feb 28, 2023
wtgodbe added a commit that referenced this pull request Mar 1, 2023
* Update sourceIndexPackageVersion

* Revert "Revert "Update SDK (#46919)" (#46943)"

This reverts commit e9ced2f.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants