Check for 'null' arguments in HttpContextServerVariableExtensions.GetServerVariable #47828
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ServerVariable We received a bug report where a customer got a NRE with this method being the source. This PR makes a nicer exception get thrown instead.
MackinnonBuck
requested review from
Tratcher,
BrennanConroy,
halter73 and
captainsafia
as code owners
ghost
added
Tratcher
approved these changes
Apr 21, 2023
|
Pardon the close/reopen shenanigans, that was to make the license/cla check re-run (it never reported a status initially). |
halter73
approved these changes
Apr 21, 2023
amcasey
added
area-networking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check for
nullarguments inHttpContextServerVariableExtensions.GetServerVariableWe received a bug report where a customer got a NRE with this method being the source. This PR makes a nicer exception get thrown instead.