Skip to content

Fix platform detection for FreeBSD #47839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 25, 2023
Merged

Fix platform detection for FreeBSD #47839

merged 1 commit into from
Apr 25, 2023

Conversation

Thefrank
Copy link
Contributor

Fix platform detection for FreeBSD

  • You've read the Contributor Guide and Code of Conduct.
  • You've included unit or integration tests for your change, where applicable.
  • You've included inline docs for your change, where applicable.
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.

Accept FreeBSD as a valid OS without need for --os-name

Description

The current version of eng/build.sh only checks for "Darwin" in uname's return and assumes "linux" otherwise. Under normal circumstances this is fine as building under FreeBSD we use --os-name FreeBSD to override this behavior. Unfortunately this is not possible when source building.

Fixes #47838

@Thefrank Thefrank requested review from a team and wtgodbe as code owners April 22, 2023 23:27
@ghost ghost added area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework community-contribution Indicates that the PR has been added by a community member labels Apr 22, 2023
@ghost
Copy link

ghost commented Apr 22, 2023

Thanks for your PR, @Thefrank. Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@ghost
Copy link

ghost commented Apr 22, 2023

Hey @dotnet/aspnet-build, looks like this PR is something you want to take a look at.

@wtgodbe wtgodbe self-assigned this Apr 25, 2023
Copy link
Member

@wtgodbe wtgodbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change!

@wtgodbe wtgodbe merged commit 99d3f22 into dotnet:main Apr 25, 2023
@ghost ghost added this to the 8.0-preview4 milestone Apr 25, 2023
@Thefrank Thefrank deleted the freebsd-fix branch July 12, 2023 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build script (sh) does not correctly detect FreeBSD
2 participants