Fixed bug in Sections #47870
Merged
Fixed bug in Sections #47870
+46
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
SteveSandersonMS
approved these changes
Apr 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed bug in Sections
When implementing the final design for Sections (adding SectionName ) I forgot to change the line where we assign
_registeredIdentifierinSectionContentto theidentifiervariable and left it as_registeredIdentifier = SectionId. This caused to not being able to remove provider for theSectionOutletand whenSectionContentwithSectionNamewas disposedSectionOutletwas still rendering the content.Same mistake in
SectionOutlet_subscribedIdentifier = SectionId. This caused weird bug in hot reload when removingSectionOutletwithSectionNamefrom the page resulting in error "Unhandled exception rendering component: There is already a subscriber to the content with the given section ID". Now fixed.Added new e2e test cases when
SectionContentwith name gets disposed and whenSectionOutletwith name gets disposed.Fixes #47552