Skip to content

[blazor] Apply disableDotnet6Compatibility to fix hotreload #47876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 25, 2023
Merged

[blazor] Apply disableDotnet6Compatibility to fix hotreload #47876

merged 1 commit into from
Apr 25, 2023

Conversation

maraf
Copy link
Member

@maraf maraf commented Apr 25, 2023

Fix regression from #47752

  • Mono disableDotnet6Compatibility: false assignes provided API to a global namespace
  • Hotreload function receiveHotReload expects global object BINDING

@maraf maraf added area-blazor Includes: Blazor, Razor Components feature-blazor-wasm This issue is related to and / or impacts Blazor WebAssembly labels Apr 25, 2023
@maraf maraf added this to the 8.0-preview4 milestone Apr 25, 2023
@maraf maraf self-assigned this Apr 25, 2023
@maraf maraf requested a review from a team as a code owner April 25, 2023 07:36
@maraf
Copy link
Member Author

maraf commented Apr 25, 2023

/cc @javiercn @MackinnonBuck

@maraf maraf merged commit b3371bb into dotnet:main Apr 25, 2023
@maraf maraf deleted the BlazorFixHotReload branch April 25, 2023 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavelsavara pavelsavara pavelsavara approved these changes

Assignees

@maraf maraf

Labels
area-blazor Includes: Blazor, Razor Components feature-blazor-wasm This issue is related to and / or impacts Blazor WebAssembly
Projects
None yet
Milestone
8.0-preview4
Development

Successfully merging this pull request may close these issues.
2 participants
@maraf @pavelsavara