Skip to content

Conversation

amcasey
Copy link
Member

@amcasey amcasey commented May 16, 2023

Print exit code when trim test fails

  • You've read the Contributor Guide and Code of Conduct.
  • You've included unit or integration tests for your change, where applicable.
  • You've included inline docs for your change, where applicable.
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.

Description

Any exit code other than 100 is considered to be a failure, but it can be helpful to know what the code was if the test contains multiple checks.

@amcasey amcasey requested review from a team and wtgodbe as code owners May 16, 2023 03:10
@ghost ghost added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label May 16, 2023
@ghost
Copy link

ghost commented May 16, 2023

Hey @dotnet/aspnet-build, looks like this PR is something you want to take a look at.

@amcasey amcasey merged commit c5a9c59 into dotnet:main May 17, 2023
@amcasey amcasey deleted the TrimTestExitCode branch May 17, 2023 18:23
@ghost ghost added this to the 8.0-preview5 milestone May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants