DO NOT REVIEW Stress test x509 test #48332
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...when using `CreateSlimBuilder`.
...since we're testing trimming behavior and add a test in the other direction (i.e. `UseHttps` does cause `X509Certificate` to be preserved).
ghost
added
the
needs-area-label
4 tasks
This reverts commit d118f30.
|
The failures have the error code I added, so they definitely indicate trimming issues and not (e.g.) crashes. |
|
On the bright side, for each run, the tests either all passed or all failed. |
|
I don't know why the windows test run doesn't show failure, but it had 10 errors (i.e. the test failed there too). |
|
I wonder if the trimmer is seeing this call and keeping the type (Note that this is my own |
mkArtakMSFT
added
area-infrastructure
|
Hey @dotnet/aspnet-build, looks like this PR is something you want to take a look at. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scratch PR to run something through CI a bunch of times.