Use Type.IsByRefLike.

[teo-tsirpanis]

Use Type.IsByRefLike.

• You've read the Contributor Guide and Code of Conduct.
• You've included unit or integration tests for your change, where applicable.
• You've included inline docs for your change, where applicable.
• There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.

Use the Type.IsByRefLike property to check if a type is a ref struct.

Description

In PropertyHelper.cs we check if the property's type is a ref struct by checking if it is a value type and has the System.Runtime.CompilerServices.IsByRefLikeAttribute applied to it. This is inefficient and unreliable in edge cases (such as a ref struct defined in an assembly targeting .NET Standard).

This PR changes the code to just call property.PropertyType.IsByRefLike, which is more efficient and returns the authoritative answer on whether the runtime considers a type to be a ref struct. RequestBuilder.cs already uses this property.

PropertyHelpers.cs is used only on projects targeting modern frameworks so there is no need to #if the change.

[ghost]

Thanks for your PR, @teo-tsirpanis. Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

[amcasey]

Seems like a nice simplification - thanks!