feat: Add StringSyntaxAttribute for guid and timespan args

[abc516]

#44535 (GuidFormat and TimeSpanFormat)

• You've read the Contributor Guide and Code of Conduct.
• There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.

Description

Adds the StringSyntaxAttribute for guid and timespan string function parameters, to specify syntax adherence.
Specifically, for the guid params, it adds it to all references of the SignalR Hub ConnectionId param and Kestrel Web Server ConnectionID .

[ghost]

Thanks for your PR, @abc516. Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

[BrennanConroy]

I don't think the GuidFormat usages are correct. There is no restriction on ConnectionID being a GUID string. See https://source.dot.net/#Microsoft.AspNetCore.Http.Connections/Internal/HttpConnectionManager.cs,c33ed873441a4544 for an example of an ID we create that is explicitly not a GUID.

[abc516]

@BrennanConroy I can remove them from the Http/Kestrel Server references. Do you have any recommendations to where I can put the GuidFormat usages?

[BrennanConroy]

Do you have any recommendations to where I can put them GuidFormat usages?

There might not be any.

[ghost]

Looks like this PR hasn't been active for some time and the codebase could have been changed in the meantime.
To make sure no breaking changes are introduced, please leave an /azp run comment here to rerun the CI pipeline and confirm success before merging the change.

[davidfowl]

I understand why this could be useful for the developers in this code base, but it doesn't seem like there's a big value in having these throughout internal and private methods in the code base.

[danmoseley]

Based on the notes above, and this has sat for a while, I'm going to close. Thanks @abc516 for the contribution.

[ghost]

Hi @danmoseley. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context.