Skip to content

Fix RequestSize-related log names in routing middleware #49740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 31, 2023
Merged

Fix RequestSize-related log names in routing middleware #49740

merged 1 commit into from
Jul 31, 2023

Conversation

captainsafia
Copy link
Member

Closes #49734.

@captainsafia captainsafia requested a review from javiercn as a code owner July 31, 2023 02:05
@ghost ghost added the area-runtime label Jul 31, 2023
@captainsafia captainsafia requested a review from JamesNK July 31, 2023 02:06
@captainsafia captainsafia added area-middleware Includes: URL rewrite, redirect, response cache/compression, session, and other general middlewares and removed area-runtime labels Jul 31, 2023
@captainsafia
Copy link
Member Author

@dotnet/aspnet-build Can I get help merging this as well? It's a small change and is blocked on a flakey test that we just quarantined.

@sebastienros sebastienros merged commit 5917847 into main Jul 31, 2023
@sebastienros sebastienros deleted the safia/fix-log-name branch July 31, 2023 16:44
@ghost ghost added this to the 8.0-rc1 milestone Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JamesNK JamesNK JamesNK approved these changes

@javiercn javiercn Awaiting requested review from javiercn

Assignees
No one assigned
Labels
area-middleware Includes: URL rewrite, redirect, response cache/compression, session, and other general middlewares
Projects
None yet
Milestone
8.0-rc1
Development

Successfully merging this pull request may close these issues.

EndpointRoutingMiddleware request size log names need improvement
3 participants
@captainsafia @JamesNK @sebastienros