Update last few projects to target netcoreapp3.0
#5128
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- #3754 - remove `#if`'s for multi-targeting where source is never multi-targeted
13 tasks
davidfowl
reviewed
Dec 15, 2018
| @@ -8,7 +8,6 @@ | |||
| using System.IO.Pipelines; | |||
| using System.Runtime.CompilerServices; | |||
| using System.Runtime.ExceptionServices; | |||
| using System.Runtime.InteropServices; | |||
There was a problem hiding this comment.
I would leave out these changes since this type is going to be moving to corefx.
There was a problem hiding this comment.
🆗 I'll revert changes to StreamPipeReader and StreamPipeWriter.
Will CoreFx also take StreamPipeReaderTests and StreamPipeWriterTests? If yes, I"ll revert changes to those classes too.
davidfowl
reviewed
Dec 15, 2018
| @@ -8,14 +8,13 @@ | |||
| using System.IO.Pipelines; | |||
| using System.Runtime.CompilerServices; | |||
| using System.Runtime.ExceptionServices; | |||
| using System.Runtime.InteropServices; | |||
| using System.Threading; | |||
| using System.Threading.Tasks; | |||
|
|
|||
| namespace Microsoft.AspNetCore.Http | |||
There was a problem hiding this comment.
Ditto, these types will be moved to corefx
|
🆙📅 to revert changes to a few classes |
natemcmaster
approved these changes
Dec 17, 2018
Tratcher
approved these changes
Dec 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#if's for multi-targeting where source is never multi-targeted