Enable unified build #54084
Enable unified build #54084
Conversation
mmitche
requested review from
BrennanConroy,
halter73,
JamesNK,
mgravell,
captainsafia,
a team and
wtgodbe
as code owners
ghost
added
the
area-infrastructure
|
@wtgodbe First draft of support for UB in aspnetcore. The goals here are that aspentcore builds a vertical (generally Target Arch+OS) in the VMR. Source build infra is used, but switches aren't. There are definitely some rough edges here and further work is required. I've annotated the PR. |
| <ExcludeFromSourceBuild | ||
| Condition="'$(ExcludeFromSourceBuild)' == '' and | ||
| '$(DotNetBuildFromSource)' == 'true' and | ||
| <ExcludeFromSourceOnlyBuild |
There was a problem hiding this comment.
Much of this is just updates to the controls names to use the new UB names and meanings.
eng/build.ps1
Outdated
| @@ -12,6 +12,9 @@ build projects, run tests, and generate code. | |||
| .PARAMETER CI | |||
| Sets up CI specific settings and variables. | |||
|
|
|||
| .PARAMETER PrepareMachine | |||
| Prepare machine for a CI run, and clean up afterwards. | |||
There was a problem hiding this comment.
These are the same changes from #54081
eng/configure-toolset.sh
Outdated
| if [ "${DotNetBuildFromSource:-false}" = false ]; then | ||
| use_installed_dotnet_cli="false" | ||
| fi | ||
| use_installed_dotnet_cli="false" |
There was a problem hiding this comment.
My hunch is that this is no longer required.
|
Covers dotnet/source-build#4022 and #43637 with caveats. |
|
Testing this in a CI build now |
dotnet-policy-service
bot
added
the
pending-ci-rerun
|
I think this is ready to go. May need additional tweaks but this should allow us to enable aspnet |
|
Ready to go |
eng/build.ps1
Outdated
| @@ -199,6 +199,8 @@ param( | |||
| Set-StrictMode -Version 2 | |||
| $ErrorActionPreference = 'Stop' | |||
|
|
|||
| echo "Building All: $All" | |||
No description provided.