Prefer keys old enough to have propagated #54309
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code for choosing a fallback key when no default was found sensibly distinguished between keys that were old enough to have propagated to all instances and those that were not. The code for choosing the preferred key should do the same. This should help in the case where two instances both discover that a new key is needed and create an immediately-activated key. One of them will get both keys back from the repository and it should choose the _older_ of the two to match the choice of of the other instance (which only knows about its own key).
ghost
added
the
|
This probably actually fixes #52678, but I want to do some more validation before I call it done. Edit: nope - you can have an older key reach shared storage later, either due to clock skew or a plain old race. |
|
While this seems more sensible than the current behavior, it doesn't obviously get us closer to fixing any races, so it may not be worth the observable change. |
captainsafia
approved these changes
Mar 4, 2024
amcasey
added a commit
to amcasey/aspnetcore
that referenced
this pull request
Aug 6, 2024
This reverts commit e72eca7. It was a speculative improvement and now we have concrete evidence of (minor) problems. Fixes dotnet#57137
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code for choosing a fallback key when no default was found sensibly distinguished between keys that were old enough to have propagated to all instances and those that were not. The code for choosing the preferred key should do the same.
This should help in the case where two instances both discover that a new key is needed and create an immediately-activated key. One of them will get both keys back from the repository and it should choose the older of the two to match the choice of of the other instance (which only knows about its own key).
Part of #52678