-
Notifications
You must be signed in to change notification settings - Fork 10.4k
Fix test CanRenderLargeComponentsWithServerRenderMode #54340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix test CanRenderLargeComponentsWithServerRenderMode #54340
Conversation
@javiercn Thanks for approving. Not sure if you want to re-review, but I encountered a further test issue in the CI run (build log):
... so I've added a bunch more code to deal with that everywhere throughout the whole E2E test suite. It's probably pretty rare (I haven't seen it before, unless it's just been introduced by some version update), and arguably it could be handled in a separate PR but I think we just want to squash flakiness as quickly as possible. |
@SteveSandersonMS were you able to reproduce the flakyness locally? It would be good to have confirmation that the fixes fix the problem, but I understand testing it locally is hard, so I'm happy to merge this and see. |
Unfortunately not - I got the |
This reverts commit 5d58631.
We saw this again in https://dev.azure.com/dnceng-public/public/_build/results?buildId=595165&view=results. #54411 hit it too, but I'm not sure how to grab the build URL now that the check has been re-run. |
Fixes CanRenderLargeComponentsWithServerRenderMode, which should allow us to unquarantine it (#49975)
The test was mistakenly using
Assert.Equal
when it should be usingBrowser.Equal
. Also it was mistakenly asserting the same thing twice, instead of asserting two different things - probably just a copy-paste error.When merged, we can mark #49975 as
test-fixed
.