[release/8.0] Change how ANCM recycles app #55288
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
requested review from
halter73,
BrennanConroy,
JamesNK and
mgravell
as code owners
ghost
added
the
area-networking
src/Servers/IIS/IIS/test/IIS.Shared.FunctionalTests/ApplicationInitializationTests.cs
Outdated
Show resolved
Hide resolved
adityamandaleeka
approved these changes
Apr 22, 2024
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
Timeout in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #52807 to release/8.0
/cc @BrennanConroy
Change how ANCM recycles app
Description
IIS can recycle for various reasons, both manually triggered and automatically triggered. When a recycle occurs IIS will start a new process (by default) and send incoming requests to the new process while it shuts down the old process. However, ANCM's handling of shutdown wasn't taking advantage of this overlapped recycle and so incoming requests were still coming to the old process while we are shutting down. Which results in 503 responses during app shutdown. This behavior is very much undesirable and is now fixed with this (opt-in) change.
Fixes #41340
Customer Impact
Customers would see 503's for incoming requests while the app is recycling, which could be exacerbated by how slow the app shuts down.
Regression?
Risk
The change is 95% behind an opt-in flag so it shouldn't have any effect on current apps.
Verification
Packaging changes reviewed?