Fix Abort Lock #55738
Merged
Fix Abort Lock #55738
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wtgodbe
requested review from
halter73,
BrennanConroy,
JamesNK and
mgravell
as code owners
ghost
added
the
area-networking
BrennanConroy
approved these changes
May 15, 2024
JamesNK
reviewed
May 16, 2024
| /// <returns><c>true</c> if already completed.</returns> | ||
| private bool CompleteUnsynchronized() | ||
| { | ||
| if (_completed) |
There was a problem hiding this comment.
This looks like it always needs to be called inside _writeLock. You can assert that (at least in debug), with something like this:
| /// Do not call this method under the _writeLock. | ||
| /// This method can call Http2OutputProducer.Stop which can acquire Http2OutputProducer._dataWriterLock | ||
| /// which is not the desired lock order | ||
| /// </summary> | ||
| private void AbortConnectionFlowControl() | ||
| { | ||
| lock (_windowUpdateLock) |
There was a problem hiding this comment.
Could can check this isn't under the lock by checking IsEntered returns false:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.