Skip to content

Reset OpenApiSchemaTransformerContext before each invocation #56905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 20, 2024
Merged

Reset OpenApiSchemaTransformerContext before each invocation #56905

merged 2 commits into from
Jul 20, 2024

Conversation

captainsafia
Copy link
Member

Closes #56899.

@captainsafia captainsafia requested a review from a team as a code owner July 19, 2024 22:55
@ghost ghost added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label Jul 19, 2024
@captainsafia captainsafia added feature-openapi area-minimal Includes minimal APIs, endpoint filters, parameter binding, request delegate generator etc labels Jul 19, 2024
halter73
halter73 approved these changes Jul 19, 2024
View reviewed changes
Copy link
Member

@halter73 halter73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if it would be better to replace all the calls to UpdateJsonTypeInfo with a single call to at the start of InnerApplySchemaTransformersAsync. I think this would be doable if we added a JsonPropertyInfo? parameter to the recursive call.

@build-analysis build-analysis bot mentioned this pull request Jul 20, 2024
Open
3 tasks
@captainsafia captainsafia enabled auto-merge (squash) July 20, 2024 03:27
@captainsafia captainsafia merged commit 0e1746b into main Jul 20, 2024
26 checks passed
@captainsafia captainsafia deleted the 56899 branch July 20, 2024 05:33
@dotnet-policy-service dotnet-policy-service bot added this to the 9.0-preview7 milestone Jul 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@halter73 halter73 halter73 approved these changes

Assignees
No one assigned
Labels
area-minimal Includes minimal APIs, endpoint filters, parameter binding, request delegate generator etc area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates feature-openapi
Projects
None yet
Milestone
9.0-preview7
Development

Successfully merging this pull request may close these issues.

OpenAPI schema transformers not working correctly for types
2 participants
@captainsafia @halter73