Skip to content

Conversation

polatengin
Copy link
Contributor

Bumping ws dependency to fix Component Vulnerability issue

ws package has a DoS attach vulnerability between v7.0.0 and v7.5.10

Details can be found here; https://security.snyk.io/package/npm/ws

GitHub Code Scanning feature shows a High Severity alert

Description

ws dependency in the package.json is pinned to v7.4.5, and it needs to be updated to at least v7.5.10

Fixes #56723

@ghost ghost added the area-signalr Includes: SignalR clients and servers label Aug 26, 2024
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Aug 26, 2024
@Marcusg62
Copy link

Thanks for doing this, I'm experiencing this issue at my org - much needed!

@jamesdten
Copy link

Also experiencing this issue at my org - really appreciate the PR!

@wtgodbe
Copy link
Member

wtgodbe commented Aug 30, 2024

Thanks for the change!

@wtgodbe wtgodbe merged commit 439510d into dotnet:main Aug 30, 2024
26 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0-preview1 milestone Aug 30, 2024
@polatengin polatengin deleted the polatengin/fixing-ws-component-vulnerability branch September 10, 2024 18:49
@timminss
Copy link

When will this make it into a version of @microsoft/signalr on npm? Looks like the latest version available there contains the impacted version of ws: https://www.npmjs.com/package/@microsoft/signalr?activeTab=code

Thanks!

@wtgodbe
Copy link
Member

wtgodbe commented Oct 16, 2024

This change was made in our 10.0 branch, which we're not shipping until next year. I can backport it to 9.0 and 8.0 so that it makes it into our next monthly release - unfortunately the branches are closed right now, so the fix won't ship until December.

@wtgodbe
Copy link
Member

wtgodbe commented Oct 16, 2024

/backport to release/9.0

@wtgodbe
Copy link
Member

wtgodbe commented Oct 16, 2024

/backport to release/8.0

Copy link
Contributor

Started backporting to release/9.0: https://github.com/dotnet/aspnetcore/actions/runs/11369683658

Copy link
Contributor

Started backporting to release/8.0: https://github.com/dotnet/aspnetcore/actions/runs/11369685243

@wtgodbe
Copy link
Member

wtgodbe commented Oct 16, 2024

Actually, I was able to get this merged in time for the 9.0.0 RTM release in November

@neoskx
Copy link

neoskx commented Jan 17, 2025

When will you publish this fix? For the latest 8.0.7, it still uses "ws": "^7.4.5"

@wtgodbe
Copy link
Member

wtgodbe commented Jan 17, 2025

When will you publish this fix? For the latest 8.0.7, it still uses "ws": "^7.4.5"

Which package are you referring to? The 8.0 SignalR package has been using 7.5.10 for some time now:

@sochetanie
Copy link

npm package still contain "ws": "^7.4.5"
https://www.npmjs.com/package/@microsoft/signalr?activeTab=code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-signalr Includes: SignalR clients and servers community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Component Vulnerability]please consider to upgrade ws in @microsoft/signalr from @^7.4.5 to @^7.5.10
7 participants