Skip to content

Merge RC2 changes into 9.0 #58296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 8, 2024
Merged

Merge RC2 changes into 9.0 #58296

merged 4 commits into from
Oct 8, 2024

Conversation

wtgodbe
Copy link
Member

@wtgodbe wtgodbe commented Oct 8, 2024

No description provided.

BrennanConroy and others added 4 commits September 22, 2024 01:09
@BrennanConroy @wtgodbe
Merged PR 42925: Merged PR 41476: Fix Http3 Pipe complete
ef65a77 
Don't complete the `PipeWriter` when it still might be used by Application code.

----
#### AI description  (iteration 1)
#### PR Classification
Bug fix

#### PR Summary
This pull request addresses a bug in the HTTP/3 implementation related to memory management and pipe completion.
- `Http3RequestTests.cs`: Added a new test to ensure memory is preserved when the connection closes.
- `Http3OutputProducer.cs`: Refactored `Dispose` method and added `Complete` method to properly handle pipe completion.
- `DiagnosticMemoryPool.cs`: Added `ContainsMemory` method to check if memory is still rented from the pool.
- `Http3Stream.cs`: Ensured `Complete` is called on `_http3Output` when the stream is closed.
- `Microsoft.AspNetCore.Server.Kestrel.Transport.Sockets.csproj`: Added `InternalsVisibleTo` for `Interop.FunctionalTests`.
@mmitche
Merged PR 42952: [internal/release/9.0-rc2] Update dependencies from …
27ccca9 
…dnceng/internal/dotnet-efcore, dnceng/internal/dotnet-runtime

This pull request updates the following dependencies

[marker]: <> (Begin:8dae0f3c-a39b-44b8-9786-989490256245)
## From https://dev.azure.com/dnceng/internal/_git/dotnet-runtime
- **Subscription**: 8dae0f3c-a39b-44b8-9786-989490256245
- **Build**: 20240917.3
- **Date Produced**: September 17, 2024 9:27:09 PM UTC
- **Commit**: 10507ab37be167432fe16d2dc71469cc193e463d
- **Branch**: refs/heads/internal/release/9.0-rc2

[DependencyUpdate]: <> (Begin)

- **Updates**:
  - **Microsoft.Bcl.AsyncInterfaces**: [from 9.0.0-rc.2.24463.7 to 9.0.0-rc.2.24467.3][1]
  - **Microsoft.Bcl.TimeProvider**: [from 9.0.0-rc.2.24463.7 to 9.0.0-rc.2.24467.3][1]
  - **Microsoft.Extensions.Caching.Abstractions**: [from 9.0.0-rc.2.24463.7 to 9.0.0-rc.2.24467.3][1]
  - **Microsoft.Extensions.Caching.Memory**: [from 9.0.0-rc.2.24463.7 to 9.0.0-rc.2.24467.3][1]
  - **Microsoft.Extensions.Configuration**: [from 9.0.0-rc.2.24463.7 to 9.0.0-rc.2.24467.3][1]
  - **Microsoft.Extensions.Configuration.Abstractions**: [from 9.0.0-rc.2.24463.7 to 9.0.0-rc.2.24467.3][1]
  - **Microsoft.Extensions.Configuration.Binder**: [from 9.0.0-rc.2.24463.7 to 9.0.0-rc.2.24467.3][1]
  - **Microsoft.Extensions.Configuration.CommandLine**: [from 9.0.0-rc.2.24463.7 to 9.0.0-rc.2.24467.3][1]
  - **Microsoft.Extensions.Configuration.EnvironmentVariables**: [from 9.0.0-rc.2.24463.7 to 9.0.0-rc.2.24467.3][1]
  - **Microsoft.Extensions.Configuration.FileExtensions**: [from 9.0.0-rc.2.24463.7 to 9.0.0-rc.2.24467.3][1]
  - **Microsoft.Extensions.Configuration.Ini**: [from 9.0.0-rc.2.24463.7 to 9.0.0-rc.2.24467.3][1]
  - **Microsoft.Extensions.Configuration.Json**: [from 9.0.0-rc.2.24463.7 to 9.0.0-rc.2.24467.3][1]
  - **Microsoft.Extensions.Configuration.UserSecrets**: [from 9.0.0-rc.2.24463.7 to 9.0.0-rc.2.24467.3][1]
  - **Microsoft.Extensions.Configuration.Xml**: [from 9.0.0-rc.2.24463.7 to 9.0.0-rc.2.24467.3][1]
  - **Microsoft.Extensions.DependencyInjection**: [from 9.0.0-rc.2.24463.7 to 9.0.0-rc.2.24467.3][1]
  - **Microsoft.Extensions.DependencyInjection.Abstractions**: [from 9.0.0-rc.2.24463.7 to 9.0.0-rc.2.24467.3][1]
  - **Microsoft.Extensions.DependencyModel**: [from 9.0.0-rc.2.24463.7 to 9.0.0-rc.2.24467.3][1]
  - **Microsoft.Extensions.Diagnostics**: [from 9.0.0-rc.2.24463.7 to 9.0.0-rc.2.24467.3][1]
  - **Microsoft.Extensions.Diagnostics.Abstractions**: [from 9.0.0-rc.2.24463.7 to 9.0.0-rc.2.24467.3][1]
  - **Microsoft.Extensions.FileProviders.Abstractions**: [from 9.0.0-rc.2.24463.7 to 9.0.0-rc.2.24467.3][1]
  - **Microsoft.Extensions.FileProviders.Composite**: [from 9.0.0-rc.2.24463.7 to 9.0.0-rc.2.24467.3][1]
  - **Microsoft.Extensions.FileProviders.Physical**: [from 9.0.0-rc.2.24463.7 to 9.0.0-rc.2.24467.3][1]
  - **Microsoft.Extensions.FileSystemGlobbing**: [from 9.0.0-rc.2.24463.7 to 9.0.0-rc.2.24467.3][1]
  - **Microsoft.Extensions.HostFactoryResolver.Sources**: [from 9.0.0-rc.2.24463.7 to 9.0.0-rc.2.24467.3][1]
  - **Microsoft.Extensions.Hosting**: [fr...
@mmitche
Merged PR 43089: [internal/release/9.0-rc2] Update dependencies from …
c70204a 
…dnceng/internal/dotnet-efcore, dnceng/internal/dotnet-runtime

This pull request updates the following dependencies

[marker]: <> (Begin:8dae0f3c-a39b-44b8-9786-989490256245)
## From https://dev.azure.com/dnceng/internal/_git/dotnet-runtime
- **Subscription**: 8dae0f3c-a39b-44b8-9786-989490256245
- **Build**: 20240923.5
- **Date Produced**: September 24, 2024 1:50:56 AM UTC
- **Commit**: 990ebf52fc408ca45929fd176d2740675a67fab8
- **Branch**: refs/heads/internal/release/9.0-rc2

[DependencyUpdate]: <> (Begin)

- **Updates**:
  - **Microsoft.Bcl.AsyncInterfaces**: [from 9.0.0-rc.2.24471.4 to 9.0.0-rc.2.24473.5][1]
  - **Microsoft.Bcl.TimeProvider**: [from 9.0.0-rc.2.24471.4 to 9.0.0-rc.2.24473.5][1]
  - **Microsoft.Extensions.Caching.Abstractions**: [from 9.0.0-rc.2.24471.4 to 9.0.0-rc.2.24473.5][1]
  - **Microsoft.Extensions.Caching.Memory**: [from 9.0.0-rc.2.24471.4 to 9.0.0-rc.2.24473.5][1]
  - **Microsoft.Extensions.Configuration**: [from 9.0.0-rc.2.24471.4 to 9.0.0-rc.2.24473.5][1]
  - **Microsoft.Extensions.Configuration.Abstractions**: [from 9.0.0-rc.2.24471.4 to 9.0.0-rc.2.24473.5][1]
  - **Microsoft.Extensions.Configuration.Binder**: [from 9.0.0-rc.2.24471.4 to 9.0.0-rc.2.24473.5][1]
  - **Microsoft.Extensions.Configuration.CommandLine**: [from 9.0.0-rc.2.24471.4 to 9.0.0-rc.2.24473.5][1]
  - **Microsoft.Extensions.Configuration.EnvironmentVariables**: [from 9.0.0-rc.2.24471.4 to 9.0.0-rc.2.24473.5][1]
  - **Microsoft.Extensions.Configuration.FileExtensions**: [from 9.0.0-rc.2.24471.4 to 9.0.0-rc.2.24473.5][1]
  - **Microsoft.Extensions.Configuration.Ini**: [from 9.0.0-rc.2.24471.4 to 9.0.0-rc.2.24473.5][1]
  - **Microsoft.Extensions.Configuration.Json**: [from 9.0.0-rc.2.24471.4 to 9.0.0-rc.2.24473.5][1]
  - **Microsoft.Extensions.Configuration.UserSecrets**: [from 9.0.0-rc.2.24471.4 to 9.0.0-rc.2.24473.5][1]
  - **Microsoft.Extensions.Configuration.Xml**: [from 9.0.0-rc.2.24471.4 to 9.0.0-rc.2.24473.5][1]
  - **Microsoft.Extensions.DependencyInjection**: [from 9.0.0-rc.2.24471.4 to 9.0.0-rc.2.24473.5][1]
  - **Microsoft.Extensions.DependencyInjection.Abstractions**: [from 9.0.0-rc.2.24471.4 to 9.0.0-rc.2.24473.5][1]
  - **Microsoft.Extensions.DependencyModel**: [from 9.0.0-rc.2.24471.4 to 9.0.0-rc.2.24473.5][1]
  - **Microsoft.Extensions.Diagnostics**: [from 9.0.0-rc.2.24471.4 to 9.0.0-rc.2.24473.5][1]
  - **Microsoft.Extensions.Diagnostics.Abstractions**: [from 9.0.0-rc.2.24471.4 to 9.0.0-rc.2.24473.5][1]
  - **Microsoft.Extensions.FileProviders.Abstractions**: [from 9.0.0-rc.2.24471.4 to 9.0.0-rc.2.24473.5][1]
  - **Microsoft.Extensions.FileProviders.Composite**: [from 9.0.0-rc.2.24471.4 to 9.0.0-rc.2.24473.5][1]
  - **Microsoft.Extensions.FileProviders.Physical**: [from 9.0.0-rc.2.24471.4 to 9.0.0-rc.2.24473.5][1]
  - **Microsoft.Extensions.FileSystemGlobbing**: [from 9.0.0-rc.2.24471.4 to 9.0.0-rc.2.24473.5][1]
  - **Microsoft.Extensions.HostFactoryResolver.Sources**: [from 9.0.0-rc.2.24471.4 to 9.0.0-rc.2.24473.5][1]
  - **Microsoft.Extensions.Hosting**: [fr...
@wtgodbe
Resolve merge conflict
4e1ee5f
@ghost ghost added the area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions label Oct 8, 2024
@wtgodbe wtgodbe merged commit 7b1b6d1 into release/9.0 Oct 8, 2024
25 checks passed
@wtgodbe wtgodbe deleted the wtgodbe/MergeRC2 branch October 8, 2024 19:32
@dotnet-policy-service dotnet-policy-service bot added this to the 9.0.0 milestone Oct 8, 2024
This was referenced Jul 22, 2025
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Merged
Closed
Closed
Open
Closed
This was referenced Jul 29, 2025
Closed
Closed
Closed
Closed
This was referenced Aug 27, 2025
Closed
Closed
Closed
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BrennanConroy BrennanConroy BrennanConroy approved these changes

@halter73 halter73 Awaiting requested review from halter73 halter73 is a code owner

@JamesNK JamesNK Awaiting requested review from JamesNK JamesNK is a code owner

@mgravell mgravell Awaiting requested review from mgravell

Assignees
No one assigned
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions
Projects
None yet
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@wtgodbe @BrennanConroy