Fix: exit code is ignored. #62314
Merged
Fix: exit code is ignored. #62314
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilonatommy
added
the
area-infrastructure
akoeplinger
approved these changes
Jun 11, 2025
good intuition! That's not it. |
|
@ilonatommy the reason why it "didn't work" is because there was actually no test failure in https://dev.azure.com/dnceng-public/public/_build/results?buildId=1065075&view=logs&j=fe94c0c9-bb8c-5d6f-3b51-887173cc2f5c&t=b4bd3469-f776-5941-b623-568498d38bde 
|
|
So "had test failures" was about quarantine? Thanks, I did not open the log details |
ilonatommy
force-pushed
the
propagate-exit-code
branch
from
00b82c6 to
84a2454
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up for #62222 after @akoeplinger's feedback. The code of E2E tests was not propagated correctly to the CI job.