Fixed the ErrorBoundary multiple errors bug #63254
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This pull request fixes a bug in Blazor's ErrorBoundary handling where multiple simultaneous errors could cause issues. The fix prevents unnecessary state updates when component initialization tasks are faulted, improving error boundary behavior.
Key changes:
- Modified
ComponentBaseto skipStateHasChanged()calls when initialization tasks are faulted - Added comprehensive test coverage for error boundary scenarios with multiple errors
- Created test components to simulate and verify error boundary behavior with faulted tasks
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/Components/Components/src/ComponentBase.cs | Added condition to prevent StateHasChanged when initialization task is faulted |
| src/Components/Components/test/ComponentBaseTest.cs | Added unit test and helper components for error boundary testing |
| src/Components/test/testassets/BasicTestApp/ErrorBoundaryTest/MultipleErrorsChild.razor | New test component that throws errors in both OnInitializedAsync and BuildRenderTree |
| src/Components/test/testassets/BasicTestApp/ErrorBoundaryTest/ErrorBoundaryCases.razor | Added UI test case for multiple errors scenario |
| src/Components/test/E2ETest/Tests/ErrorBoundaryTest.cs | Added E2E test for multiple errors handling |
src/Components/test/testassets/BasicTestApp/ErrorBoundaryTest/ErrorBoundaryCases.razor
Outdated
Show resolved
Hide resolved
javiercn
reviewed
Aug 14, 2025
javiercn
approved these changes
Aug 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the ErrorBoundary multiple errors bug
Description
This pull request enhances error handling in Blazor components, especially around error boundaries and faulted tasks during component initialization and rendering. It introduces new tests and supporting components to ensure that exceptions thrown in lifecycle methods or during rendering are correctly captured by error boundaries, and that error boundaries can handle multiple simultaneous errors.
Changes:
ComponentBaseto avoid callingStateHasChangedwhen the initialization task is faulted, preventing unnecessary state updates after errors.ComponentBaseTest.csto verify that error boundary capture exceptions from faulted tasks inOnInitializedAsyncand during rendering, and that these errors are surfaced correctly.TestErrorBoundaryandTestComponentErrorBuildRenderTreetest components to simulate and verify error boundary behavior with faulted tasks and rendering errors.Fixes #39814