-
Notifications
You must be signed in to change notification settings - Fork 10.4k
Remove QuarantinedTest attributes from Razor functional test methods #63265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove QuarantinedTest attributes from Razor functional test methods #63265
Conversation
Co-authored-by: radical <[email protected]>
@copilot also unquarantine |
…StartupTest methods Co-authored-by: radical <[email protected]>
Done! I've removed the QuarantinedTest attributes from both |
@wtgodbe who would be the correct code owner to review+approve this? Also, what needs to be done for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes quarantine attributes from four Razor functional test methods to reintegrate them into the normal test suite. The tests were previously quarantined due to issues tracked in GitHub issue #56553, which has now been resolved.
Key Changes
- Removes
[QuarantinedTest]
attributes from four test methods across two test classes - Removes unused
using Microsoft.AspNetCore.InternalTesting;
import statements - Enables previously quarantined tests to run as part of the standard test execution
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
File | Description |
---|---|
RazorRuntimeCompilationHostingStartupTest.cs | Removes QuarantinedTest attributes from 2 test methods and unused import |
RazorBuildTest.cs | Removes QuarantinedTest attributes from 2 test methods and unused import |
@copilot Add back the |
Co-authored-by: radical <[email protected]>
Added back the |
src/Mvc/test/Mvc.FunctionalTests/RazorRuntimeCompilationHostingStartupTest.cs
Outdated
Show resolved
Hide resolved
You can ping me for quarantining/unquarantining tests
You can ignore it, that's a bug in PolicyBot - it gets confused by Copilot starting the PR with an empty commit |
Removes
[QuarantinedTest]
attributes from four test methods across two test classes to unquarantine them and allow them to run as part of the normal test suite:RazorBuildTest.cs:
RazorViews_AreUpdatedOnChange
RazorPages_AreUpdatedOnChange
RazorRuntimeCompilationHostingStartupTest.cs:
RazorViews_CanBeServedAndUpdatedViaRuntimeCompilation
RazorPages_CanBeServedAndUpdatedViaRuntimeCompilation
The
using Microsoft.AspNetCore.InternalTesting;
statements are retained in both files as they are needed for theLoggedTest
base class,TestContext
, andLogLevel
attributes used by these test classes.Fixes #56553
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.