Skip to content

Conversation

Copilot
Copy link
Contributor

@Copilot Copilot AI commented Aug 15, 2025

Removes [QuarantinedTest] attributes from four test methods across two test classes to unquarantine them and allow them to run as part of the normal test suite:

RazorBuildTest.cs:

  • RazorViews_AreUpdatedOnChange
  • RazorPages_AreUpdatedOnChange

RazorRuntimeCompilationHostingStartupTest.cs:

  • RazorViews_CanBeServedAndUpdatedViaRuntimeCompilation
  • RazorPages_CanBeServedAndUpdatedViaRuntimeCompilation

The using Microsoft.AspNetCore.InternalTesting; statements are retained in both files as they are needed for the LoggedTest base class, TestContext, and LogLevel attributes used by these test classes.

Fixes #56553


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

@Copilot Copilot AI changed the title [WIP] Un-quarantine RazorBuildTest.RazorViews_AreUpdatedOnChange and RazorPages_AreUpdatedOnChange tests Remove QuarantinedTest attributes from RazorBuildTest methods Aug 15, 2025
@Copilot Copilot AI requested a review from radical August 15, 2025 05:28
Copilot finished work on behalf of radical August 15, 2025 05:28
@radical
Copy link
Member

radical commented Aug 15, 2025

@copilot also unquarantine Microsoft.AspNetCore.Mvc.FunctionalTests.RazorRuntimeCompilationHostingStartupTest.RazorViews_CanBeServedAndUpdatedViaRuntimeCompilation and Microsoft.AspNetCore.Mvc.FunctionalTests.RazorRuntimeCompilationHostingStartupTest.RazorPages_CanBeServedAndUpdatedViaRuntimeCompilation in the same way.

Copy link
Contributor Author

Copilot AI commented Aug 15, 2025

@copilot also unquarantine Microsoft.AspNetCore.Mvc.FunctionalTests.RazorRuntimeCompilationHostingStartupTest.RazorViews_CanBeServedAndUpdatedViaRuntimeCompilation and `Microsoft.AspNetCore.Mvc.Func...

Done! I've removed the QuarantinedTest attributes from both RazorViews_CanBeServedAndUpdatedViaRuntimeCompilation and RazorPages_CanBeServedAndUpdatedViaRuntimeCompilation methods in RazorRuntimeCompilationHostingStartupTest.cs, along with the unused using Microsoft.AspNetCore.InternalTesting; statement. Both tests are now unquarantined and will run as part of the normal test suite. (commit: 0c61179)

@Copilot Copilot AI changed the title Remove QuarantinedTest attributes from RazorBuildTest methods Remove QuarantinedTest attributes from Razor functional test methods Aug 15, 2025
Copilot finished work on behalf of radical August 15, 2025 05:41
@radical
Copy link
Member

radical commented Aug 15, 2025

@wtgodbe who would be the correct code owner to review+approve this?

Also, what needs to be done for You've submitted a PR that modifies code that is shared with https://github.com/dotnet/runtime . Please make sure you synchronize this code with the changes in that repo! ?

@radical radical marked this pull request as ready for review August 15, 2025 05:42
@Copilot Copilot AI review requested due to automatic review settings August 15, 2025 05:42
@radical radical requested a review from a team as a code owner August 15, 2025 05:42
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes quarantine attributes from four Razor functional test methods to reintegrate them into the normal test suite. The tests were previously quarantined due to issues tracked in GitHub issue #56553, which has now been resolved.

Key Changes

  • Removes [QuarantinedTest] attributes from four test methods across two test classes
  • Removes unused using Microsoft.AspNetCore.InternalTesting; import statements
  • Enables previously quarantined tests to run as part of the standard test execution

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
RazorRuntimeCompilationHostingStartupTest.cs Removes QuarantinedTest attributes from 2 test methods and unused import
RazorBuildTest.cs Removes QuarantinedTest attributes from 2 test methods and unused import

@radical radical requested a review from wtgodbe August 15, 2025 05:42
@radical
Copy link
Member

radical commented Aug 15, 2025

@copilot Add back the using Microsoft.AspNetCore.InternalTesting; as they are needed for other types being referenced.

Copy link
Contributor Author

Copilot AI commented Aug 15, 2025

@copilot Add back the using Microsoft.AspNetCore.InternalTesting; as they are needed for other types being referenced.

Added back the using Microsoft.AspNetCore.InternalTesting; statements to both files as they are needed for the LoggedTest base class, TestContext, and LogLevel attributes used by these test classes. (commit: 01ec93d)

Copilot finished work on behalf of radical August 15, 2025 06:11
@Copilot Copilot AI requested a review from radical August 15, 2025 06:11
@wtgodbe
Copy link
Member

wtgodbe commented Aug 15, 2025

@wtgodbe who would be the correct code owner to review+approve this?

You can ping me for quarantining/unquarantining tests

Also, what needs to be done for You've submitted a PR that modifies code that is shared with https://github.com/dotnet/runtime . Please make sure you synchronize this code with the changes in that repo! ?

You can ignore it, that's a bug in PolicyBot - it gets confused by Copilot starting the PR with an empty commit

@radical radical merged commit 8f16ba0 into main Aug 15, 2025
29 checks passed
@radical radical deleted the copilot/fix-fc99e689-1aa8-49ea-b597-8d6b41f35ae7 branch August 15, 2025 17:12
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0-rc1 milestone Aug 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Quarantine RazorViews_AreUpdatedOnChange and RazorPages_AreUpdatedOnChange
4 participants