Re-enable FormWithParentBindingContextTest.CanUseFormWithMethodGet
#63356
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This pull request re-enables a previously quarantined test by creating a new test class with specialized browser configuration to handle Chrome's back/forward cache behavior. The test CanUseFormWithMethodGet was moved from FormWithParentBindingContextTest to a new dedicated class FormWithNoBackForwardCacheTest with proper browser context configuration.
- Introduces a new browser context
BackForwardCacheContextthat disables Chrome's back/forward cache - Moves the quarantined test to a new test class with the specialized browser configuration
- Re-enables the test with both enhanced navigation scenarios (true/false)
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| BrowserFixture.cs | Adds new browser context constant and Chrome argument to disable back/forward cache |
| FormWithParentBindingContextTest.cs | Removes the quarantined test method CanUseFormWithMethodGet |
| FormWithNoBackForwardCacheTest.cs | New test class containing the moved test with specialized browser context |
...onents/test/E2ETest/ServerRenderingTests/FormHandlingTests/FormWithNoBackForwardCacheTest.cs
Show resolved
Hide resolved
ilonatommy
reviewed
Aug 21, 2025
...onents/test/E2ETest/ServerRenderingTests/FormHandlingTests/FormWithNoBackForwardCacheTest.cs
Outdated
Show resolved
Hide resolved
ilonatommy
approved these changes
Aug 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-enable
FormWithParentBindingContextTest.CanUseFormWithMethodGetDescription
This pull request re-enables
FormWithParentBindingContextTest.CanUseFormWithMethodGetby refactoring the test coverage for form handling with browser back/forward navigation by moving the relevant test fromFormWithParentBindingContextTestto a new dedicated test class,FormWithNoBackForwardCacheTest. Additionally, it introduces a new browser context and configuration to ensure correct browser behavior for these tests.Changes
CanUseFormWithMethodGettest has been removed fromFormWithParentBindingContextTestand added to a new file and class,FormWithNoBackForwardCacheTestwith different browser context.BackForwardCacheContext, toBrowserFixturefor tests needing control over Chrome's back/forward cache.Reasoning behind changes:
In the recent changes in Chrome the Back/forward cache is now enabled by default. Due to this
autocomplete="off"is not working correctly in the test. The new created ServerFixtureContext that disables this default behaviour in Chrome.Fixes #61882