Skip to content

Fix Microsoft.AspNetCore version in baseline #7556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 14, 2019
Merged

Conversation

dougbu
Copy link
Contributor

@dougbu dougbu commented Feb 13, 2019

  • odd that Microsoft.AspNetCore.Server.IISIntegration didn't have correct version before…

- odd that Microsoft.AspNetCore.Server.IISIntegration didn't have correct version before…
@natemcmaster
Copy link
Contributor

By chance, have you done anything to verify that we aren't missing any other out-of-date baseline entries?

@natemcmaster natemcmaster added the Servicing-consider Shiproom approval is required for the issue label Feb 13, 2019
@natemcmaster natemcmaster added this to the 2.1.x milestone Feb 13, 2019
@dougbu
Copy link
Contributor Author

dougbu commented Feb 13, 2019

By chance, have you done anything to verify that we aren't missing any other out-of-date baseline entries?

I was about to do that. Wanted to get this fixed while it was in our faces 😸

@natemcmaster natemcmaster requested a review from Eilon February 13, 2019 23:54
@natemcmaster
Copy link
Contributor

Will let @Eilon decide if this is a shiproom ask or tell.

@Eilon
Copy link
Contributor

Eilon commented Feb 14, 2019

Definitely needs to go through shiproom because this affects what we ship. Please have the test ready in the PR, add the shiproom template to the top of the PR, and send mail.

@Eilon
Copy link
Contributor

Eilon commented Feb 14, 2019

Oh and when you add the test, please run the test on the reverted files to see that it found what you found!

@Eilon Eilon added the feature-platform Deprecated: Cross-cutting issues related to ASP.NET Core as a platform label Feb 14, 2019
@dougbu
Copy link
Contributor Author

dougbu commented Feb 14, 2019

Description

As described in #7546, the 2.1.8 release downgraded Microsoft.AspNetCore dependencies to version 2.1.6. This in turn leads to FileLoadExceptions as in #3503 (comment)

Customer impact

As one commenter said, we're entering ASP.NET Core version hell 😦

Users have multiple workarounds:

  1. add <PackageReference Include="Microsoft.AspNetCore" Version="2.1.7" /> (NB: this is NOT the .App package)
  2. Remove version from AspNetCore.App <PackageReference Include="Microsoft.AspNetCore.App" />
  3. Update AspNetCore.App: <PackageReference Include="Microsoft.AspNetCore.App" Version="2.1.8" />

Regression?

Yes. Earlier 2.1.x releases did not have this issue.

Risk

Minimal. We are adding tests to ensure this issue does not occur going forward.

@vivmishra vivmishra added Servicing-approved Shiproom has approved the issue and removed Servicing-consider Shiproom approval is required for the issue labels Feb 14, 2019
@vivmishra vivmishra modified the milestones: 2.1.x, 2.1.9 Feb 14, 2019
@vivmishra
Copy link

Approved for 2.1.9.

@dougbu dougbu merged commit 8d58116 into release/2.1 Feb 14, 2019
@dougbu dougbu deleted the dougbu/fixup.2.1.9 branch February 14, 2019 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-platform Deprecated: Cross-cutting issues related to ASP.NET Core as a platform Servicing-approved Shiproom has approved the issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants