-
Notifications
You must be signed in to change notification settings - Fork 10.3k
Fix Microsoft.AspNetCore version in baseline #7556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
dougbu
commented
Feb 13, 2019
- odd that Microsoft.AspNetCore.Server.IISIntegration didn't have correct version before…
- odd that Microsoft.AspNetCore.Server.IISIntegration didn't have correct version before…
By chance, have you done anything to verify that we aren't missing any other out-of-date baseline entries? |
I was about to do that. Wanted to get this fixed while it was in our faces 😸 |
Will let @Eilon decide if this is a shiproom ask or tell. |
Definitely needs to go through shiproom because this affects what we ship. Please have the test ready in the PR, add the shiproom template to the top of the PR, and send mail. |
Oh and when you add the test, please run the test on the reverted files to see that it found what you found! |
DescriptionAs described in #7546, the 2.1.8 release downgraded Microsoft.AspNetCore dependencies to version 2.1.6. This in turn leads to Customer impactAs one commenter said, we're entering ASP.NET Core version hell 😦 Users have multiple workarounds:
Regression?Yes. Earlier 2.1.x releases did not have this issue. RiskMinimal. We are adding tests to ensure this issue does not occur going forward. |
Approved for 2.1.9. |