Skip to content

Convert BlazorExtension to SDK style project #7588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 15, 2019

Conversation

pranavkm
Copy link
Contributor

Fixes #7135

@pranavkm
Copy link
Contributor Author

The vsixmanifest has the right version - <Identity Id="Microsoft.VisualStudio.BlazorExtension" Version="16.0.424242.424242" Language="en-US" Publisher="Microsoft" /> and the assembly metadata looks right:

[assembly: CompilationRelaxations(8)]
[assembly: RuntimeCompatibility]
[assembly: Debuggable()]
[assembly: TargetFramework(".NETFramework,Version=v4.7.2")]
[assembly: AssemblyMetadata("BuildNumber", "t000")]
[assembly: AssemblyMetadata("CommitHash", "5e5904dc6571c8f7bbc4ab9d5f1274ec40520195")]
[assembly: AssemblyMetadata("SourceCommitUrl", "https://github.com/aspnet/AspNetCore/tree/5e5904dc6571c8f7bbc4ab9d5f1274ec40520195")]
[assembly: AssemblyMetadata("Serviceable", "True")]
[assembly: AssemblyCompany("Microsoft Corporation.")]
[assembly: AssemblyConfiguration("Debug")]
[assembly: AssemblyCopyright("© Microsoft Corporation. All rights reserved.")]
[assembly: AssemblyFileVersion("0.8.0.42424")]
[assembly: AssemblyInformationalVersion("16.0.424242.424242")]
[assembly: AssemblyProduct("Microsoft ASP.NET Core")]
[assembly: AssemblyTitle("Microsoft.VisualStudio.BlazorExtension")]
[assembly: NeutralResourcesLanguage("en-US")]
[assembly: AssemblyVersion("0.8.0.0")]

Is there anything else that I'm missing here?

@natemcmaster
Copy link
Contributor

Does debugging work in VS 2019? I was under the impression the VSIX tooling didn't support this project style yet.

@pranavkm
Copy link
Contributor Author

@natemcmaster made some tweaks, which makes Ctrl-F5 \ debugging work.

@natemcmaster
Copy link
Contributor

Nice 😎

Copy link
Contributor

@natemcmaster natemcmaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know as much @rynowak about how VSIX stuff is supposed to work. Added a few minor comments, but as long as it works. :shipit:

</PropertyGroup>
<PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Debug|AnyCPU' ">
<DebugSymbols>true</DebugSymbols>
<DebugType>full</DebugType>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not 100% sure, but I think this Microsoft.NET.Sdk sets this to portable. Not sure if that's important or not.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked the Razor vsix, and it produces portable pdbs:

image

Guess it doesn't matter.

@pranavkm pranavkm force-pushed the prkrishn/sdk-style-project branch from 4b55c30 to 0bc9a74 Compare February 14, 2019 21:57
@Eilon Eilon added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label Feb 15, 2019
@pranavkm pranavkm force-pushed the prkrishn/sdk-style-project branch from 0bc9a74 to 076bc0a Compare February 15, 2019 20:51
@pranavkm pranavkm merged commit 7daa0e0 into master Feb 15, 2019
@pranavkm pranavkm deleted the prkrishn/sdk-style-project branch February 15, 2019 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants