-
Notifications
You must be signed in to change notification settings - Fork 10.4k
Convert BlazorExtension to SDK style project #7588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The vsixmanifest has the right version -
Is there anything else that I'm missing here? |
Does debugging work in VS 2019? I was under the impression the VSIX tooling didn't support this project style yet. |
@natemcmaster made some tweaks, which makes Ctrl-F5 \ debugging work. |
Nice 😎 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know as much @rynowak about how VSIX stuff is supposed to work. Added a few minor comments, but as long as it works.
src/Components/Blazor/BlazorExtension/src/Microsoft.VisualStudio.BlazorExtension.csproj
Show resolved
Hide resolved
</PropertyGroup> | ||
<PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Debug|AnyCPU' "> | ||
<DebugSymbols>true</DebugSymbols> | ||
<DebugType>full</DebugType> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not 100% sure, but I think this Microsoft.NET.Sdk sets this to portable. Not sure if that's important or not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
src/Components/Blazor/BlazorExtension/src/Microsoft.VisualStudio.BlazorExtension.csproj
Show resolved
Hide resolved
4b55c30
to
0bc9a74
Compare
0bc9a74
to
076bc0a
Compare
Fixes #7135