Skip to content

Make reads that return canceled ReadResult throw #7618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 16, 2019
Merged

Make reads that return canceled ReadResult throw #7618

merged 1 commit into from
Feb 16, 2019

Conversation

jkotalik
Copy link
Contributor

Noticed in #7603

@jkotalik jkotalik mentioned this pull request Feb 15, 2019
Merged
davidfowl
davidfowl approved these changes Feb 15, 2019
View reviewed changes
Copy link
Member

@davidfowl davidfowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jkotalik jkotalik closed this Feb 15, 2019
@jkotalik jkotalik reopened this Feb 15, 2019
@jkotalik jkotalik closed this Feb 15, 2019
@jkotalik jkotalik reopened this Feb 15, 2019
@jkotalik jkotalik merged commit 60b00fa into master Feb 16, 2019
@jkotalik jkotalik deleted the jkotalik/readOnlyCancel branch February 16, 2019 00:12
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidfowl davidfowl davidfowl approved these changes

@Tratcher Tratcher Tratcher approved these changes

@pakrym pakrym Awaiting requested review from pakrym

Assignees
No one assigned
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jkotalik @davidfowl @Tratcher @Eilon @amcasey