Add baseline version test #7627
Conversation
Eilon
added
the
feature-platform
once you have approval from 
| var localAssemblyVersion = AssemblyName.GetAssemblyName(file)?.Version; | ||
| var splitPath = file.Split('\\'); | ||
| var dllName = splitPath[splitPath.Length - 1]; | ||
| Assert.True(nugetAssemblyVersions.ContainsKey(dllName), $"Expected {dllName} to be in the downloaded dlls"); |
There was a problem hiding this comment.
Oh and BTW just checking, are there are no xUnit asserts for these two asserts here? Usually Assert.True is frowned upon, unless there's no other reasonable choice.
There was a problem hiding this comment.
Assert.Contains(nugetAssemblyVersions.Keys, ...) should work here. The only supposed loss would be the custom error message when it fails.
There was a problem hiding this comment.
We could change to use the Assert.Contains api. The error message becomes slightly less clear. I'm indifferent.
| @@ -34,6 +38,7 @@ | |||
| <PackageReference Include="xunit" Version="$(XunitPackageVersion)" /> | |||
| <PackageReference Include="xunit.analyzers" Version="$(XunitAnalyzersPackageVersion)" /> | |||
| <PackageReference Include="xunit.runner.visualstudio" Version="$(XunitRunnerVisualstudioPackageVersion)" /> | |||
| <PackageReference Include="McMaster.Extensions.CommandLineUtils" Version="2.2.2" /> | |||
There was a problem hiding this comment.
I know this is test-only but have we used @natemcmaster's private packages elsewhere?
There was a problem hiding this comment.
I mimicked here what we did in the internal repo.
| var localAssemblyVersion = AssemblyName.GetAssemblyName(file)?.Version; | ||
| var splitPath = file.Split('\\'); | ||
| var dllName = splitPath[splitPath.Length - 1]; | ||
| Assert.True(nugetAssemblyVersions.ContainsKey(dllName), $"Expected {dllName} to be in the downloaded dlls"); |
There was a problem hiding this comment.
Assert.Contains(nugetAssemblyVersions.Keys, ...) should work here. The only supposed loss would be the custom error message when it fails.
Issue: #7546