Skip to content

Use default VC toolset #9332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 12, 2019
Merged

Use default VC toolset #9332

merged 4 commits into from
Apr 12, 2019

Conversation

dougbu
Copy link
Contributor

@dougbu dougbu commented Apr 12, 2019

  • aspnet/AspNetCore-Internal#2246

@dougbu
Use default VC toolset
d62e8da 
- aspnet/AspNetCore-Internal#2246
@dougbu dougbu requested review from javiercn, jkotalik and a team April 12, 2019 16:13
javiercn
javiercn approved these changes Apr 12, 2019
View reviewed changes
Copy link
Member

@javiercn javiercn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on what the VS error tells me and what @jkotalik suggested, this should be ok.

@jkotalik
Copy link
Contributor

@javiercn can you try that locally to make sure it works? We won't get validation on CI with this change.

@jkotalik
Copy link
Contributor

From @javiercn

It's like 6:30pm in Spain

Aka I'll test it shortly.

@javiercn
Copy link
Member

@jkotalik You're such a :trollface:

I'll test it once its merged
😄

@jkotalik
Copy link
Contributor

This the only thing I got working locally. I also think it's the only way this will work on CI.

@Eilon Eilon added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Apr 12, 2019
@analogrelay analogrelay added this to the 3.0.0-preview5 milestone Apr 12, 2019
@analogrelay analogrelay removed their request for review April 12, 2019 17:34
dougbu
dougbu commented Apr 12, 2019
View reviewed changes
Copy link
Contributor Author

@dougbu dougbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it works, 🆗 but what about Installers\Windows\AspNetCoreModule-Setup//.vcxproj ?

@jkotalik
Copy link
Contributor

@dougbu this is what was generated when using the Property Pages in VC++ tooling. I agree it is horrible and I can simplify it, but it is auto generated.

@jkotalik
Copy link
Contributor

🆙 📅

@jkotalik
Copy link
Contributor

This is blocking people so if this passes, I'm merging btw.

@jkotalik
Copy link
Contributor

gah communication errors <_<

@jkotalik jkotalik closed this Apr 12, 2019
@jkotalik jkotalik reopened this Apr 12, 2019
@jkotalik jkotalik merged commit a54646f into master Apr 12, 2019
@jkotalik jkotalik deleted the dougbu/default.toolset.2246 branch April 12, 2019 23:28
@natemcmaster natemcmaster mentioned this pull request Apr 17, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javiercn javiercn javiercn approved these changes

@jkotalik jkotalik jkotalik approved these changes

@Tratcher Tratcher Awaiting requested review from Tratcher

Assignees
No one assigned
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Milestone
3.0.0-preview5
Development

Successfully merging this pull request may close these issues.
5 participants
@dougbu @jkotalik @javiercn @analogrelay @Eilon