This repository was archived by the owner on Apr 20, 2023. It is now read-only.
Rename --source-feed to --add-source #9164
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wli3
force-pushed
the
rename-to-add-source
branch
from
9120085 to
d51926a
Compare
|
LGTM |
|
preparing shiproom email |
peterhuene
reviewed
Apr 27, 2018
| <data name="SourceFeedOptionName" xml:space="preserve"> | ||
| <value>SOURCE_FEED</value> | ||
| <data name="AddSourceOptionName" xml:space="preserve"> | ||
| <value>ADD_SOURCE</value> |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
peterhuene
suggested changes
Apr 27, 2018
added 2 commits
April 27, 2018 14:08
wli3
force-pushed
the
rename-to-add-source
branch
from
4a80192 to
33aa705
Compare
peterhuene
approved these changes
Apr 27, 2018
|
I agree; current verbiage is confusing. |
|
@dotnet-bot Test CentOS7.1 x64 Debug Build |
|
Marking WIP until the branches are open for RTM changes. |
livarcocc
changed the title
livarcocc
changed the title
|
@dotnet-bot Test CentOS7.1 x64 Debug Build |
ghost
mentioned this pull request
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/dotnet/cli/issues/9062