-
Notifications
You must be signed in to change notification settings - Fork 4.9k
Update libraries for preview 7 #10000
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dotnet10-p7
Are you sure you want to change the base?
Conversation
@ericstj @kunalspathak Assigning this to you based on the preview 6 Runtime PR reviewer pattern (PR #9948). |
Adding @artl93 to drive notes for libraries. |
@@ -11,3 +11,84 @@ Here's a summary of what's new in .NET Libraries in this preview release: | |||
## Feature | |||
|
|||
Something about the feature | |||
|
|||
## Launch Windows processes in new process group |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dotnet/area-system-diagnostics-process
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you @jozkee !
using System.Runtime.InteropServices; | ||
using System.Threading; | ||
|
||
class Program |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The following example is complex, but correct. And it will most likely match the real world use case.
GenerateConsoleCtrlEvent(CTRL_C_EVENT, (uint)process.Id); | ||
process.WaitForExit(); | ||
|
||
Console.WriteLine("Child process terminated gracefully, continue with the parent process logic if needed."); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we read the log.txt
file output and display it here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wanted to show the need of properly dispose unmanaged resources (I'm open to better examples!). I don't think we need to read it back in the parent branch.
In Networking, |
This PR updates the libraries file for preview 7. Please make any additional changes to this based on the new items.