This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Port BenchmarksGame updates to release/1.1.0 #14094
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Match them to current master (@c02bf5d) and release/2.0.0 (@0e937e2) to facilitate comparing across releases.
|
@dotnet-bot test Windows_NT x64 perf |
AndyAyersMS
reviewed
Sep 20, 2017
Not sure what you're referring to... the part where I changed the base of the literals? |
|
Yes, change |
Removing binary literals allows building this test with an older C# compiler; change the others with them to improve readability.
JosephTremoulet
force-pushed
the
BenchmarksGame/1.1.0
branch
from
d75f93c to
2820bd8
Compare
|
Ok; updated. |
AndyAyersMS
approved these changes
Sep 20, 2017
|
CI error is a timeout in one of the new tests. Need to see if it's just timing out or if 1.1 has bad codegen for this test somehow... |
|
Other CI error is also a timeout, though this one doesn't indicate which test was long-running, just that the test run as a whole timed out. Suspicious that there were timeouts on two legs using x86 ryujit for codegen. When I build locally, though:
Not sure what to make of this / how to proceed... I'm tempted to add the test to an exclusion list (and file an issue?), since matching it to current official BenchmarkDotNet sources is still what we want and what this change does. @AndyAyersMS, @jorive, any opinions? |
|
@JosephTremoulet What VS version do you have locally? I think VS2015 is required to build 1.1 |
|
Building with VS2015 succeeded, but the x86 checked variant of the test completes in 1.2 seconds... going to retry the legs. @dotnet-bot test Windows_NT x86 ryujit Checked Build and Test, test Linux ARM Emulator Cross Debug Build |
|
@dotnet-bot help |
|
Welcome to the dotnet/coreclr Repository The following is a list of valid commands on this PR. To invoke a command, comment the indicated phrase on the PR The following commands are valid for all PRs and repositories. Click to expand
The following jobs are launched by default for each PR against dotnet/coreclr:release/1.1.0. Click to expand
The following optional jobs are available in PRs against dotnet/coreclr:release/1.1.0. Click to expand
Have a nice day! |
|
@dotnet-bot test Linux ARM Emulator Cross Debug Build |
|
Linux rerun passed. Windows rerun failed again, this time with timeouts in both reverse-complement-6 (as before) and fasta-1... :( |
|
@JosephTremoulet what are the next steps? open an issue and disable the tests? |
Opened issue #14191 to follow up.
|
@jorive yes, I think so; I've opened issue #14191 and pushed an update with the exclusions. |
|
Would the exclusion work for performance? Or would it become a bottleneck there? |
Hard to say, I haven't been able to reproduce the problem outside of CI runs. Is there a trigger phrase to get the CI system to run the performance tests you're concerned about to see how they fare? |
|
@dotnet-bot test Windows_NT x64 perf |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the release branches to be in sync with master, to simplify comparing the performance of these benchmarks across releases.