Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Port #14287 to release/2.0.0 #14898

Merged
merged 2 commits into from
Nov 13, 2017
Merged

Port #14287 to release/2.0.0 #14898

merged 2 commits into from
Nov 13, 2017

Conversation

tannergooding
Copy link
Member

@tannergooding
Copy link
Member Author

Also FYI. @jorive, @AndyAyersMS, and @RussKeldorph

jorive
jorive approved these changes Nov 7, 2017
View reviewed changes
Copy link

@jorive jorive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tannergooding
Copy link
Member Author

Could I get sign-off to merge despite the job failures?

Looks to be an issue with the job and is unrelated to my changes:

diff.cs(22,31): error CS8137: Cannot define a class or member that utilizes tuples because the compiler required type 'System.Runtime.CompilerServices.TupleElementNamesAttribute' cannot be found. Are you missing a reference? [D:\j\workspace\x64_windows_n---6e28d9f6\jitutils\src\jit-diff\jit-diff.csproj]

@AndyAyersMS
Copy link
Member

That formatting issue should be fixed. now. Let's retry and see:

@dotnet-bot test Windows_NT x64 Formatting
@dotnet-bot test Ubuntu x64 Formatting

@tannergooding tannergooding merged commit 7ed946a into dotnet:release/2.0.0 Nov 13, 2017
@tannergooding tannergooding deleted the benchmarks-game-2.0.0 branch January 17, 2018 01:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@AndyAyersMS AndyAyersMS AndyAyersMS approved these changes

@jorive jorive jorive approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tannergooding @AndyAyersMS @jorive